From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Windows mingw64 and cygwin builds broken Date: Fri, 13 Nov 2015 14:18:14 +0000 Message-ID: References: <867flnrnhg.fsf@gmail.com> <83y4e3gdbb.fsf@gnu.org> <86y4e2rhom.fsf@gmail.com> <836116gt5t.fsf@gnu.org> <86a8qiyzgx.fsf@gmail.com> <83si4af2ue.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447424423 505 80.91.229.3 (13 Nov 2015 14:20:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Nov 2015 14:20:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 13 15:20:14 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZxFCo-0002Pp-6q for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2015 15:19:58 +0100 Original-Received: from localhost ([::1]:53265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxFCn-0000lx-EG for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2015 09:19:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxFCC-0008TK-VI for emacs-devel@gnu.org; Fri, 13 Nov 2015 09:19:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxFC9-00022T-0N for emacs-devel@gnu.org; Fri, 13 Nov 2015 09:19:20 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:52773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxFC8-00022N-JX for emacs-devel@gnu.org; Fri, 13 Nov 2015 09:19:16 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZxFBq-0001Xt-Mi for emacs-devel@gnu.org; Fri, 13 Nov 2015 15:18:58 +0100 Original-Received: from uk.solarflare.com ([193.34.186.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Nov 2015 15:18:58 +0100 Original-Received: from andrewjmoreton by uk.solarflare.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Nov 2015 15:18:58 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 52 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: uk.solarflare.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (windows-nt) Cancel-Lock: sha1:YbDlseu+V+8yDqXNKOpjQYywGtQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194363 Archived-At: On Fri 13 Nov 2015, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Fri, 13 Nov 2015 10:18:22 +0000 >> >> Both the cygwin-w32 and mingw64 builds now need to be configured with >> --without-dbus to avoid a crash when dumping. > > That's not what I intended. It was supposed to work even when D-Bus > is compiled in. The code that supports w32 notifications and the > related DEFSYM's are conditioned on non-Cygwin build and on D-Bus not > being available. When D-Bus _is_ available, then only the DEFSYM's in > dbusbind.c were supposed to be visible, and those in w32fns.c > invisible, together with their supporting code. But somehow this is > not working... > > Ah, I think I see the problem: makedoc doesn't take preprocessor > directives into account. I need to think how to fix that. > >> As users may want to use D-Bus with cygwin-w32 emacs (and possibly with >> mingw64 emacs), a configure option is needed for the w32-notifications. > > No, I don't think we need a configure option. The intent was to > provide the native w32 notifications only if D-Bus is not available, > because the former support only a small subset of the functionality. That still leaves users without the ability to turn both off (unless they patch the sources before building). >> Can you also please explain what was wrong with the patch I sent, which >> was simpler than your solution. > > It used the same DEFSYM twice in certain configurations, which I > don't like. Fair enough - I agree that while it "works" at the moment, it is potentially fragile. >> Does it make sense to build emacs with support for both D-Bus and >> w32-notifications, and for the user to choose which is enabled at >> runtime ? > > Not to me, it doesn't. And anyway, this is a separate issue; how to > fix the double definition of ':timeout' is unrelated to whether we > want to support both D-Bus notifications and w32 notifications in the > same build. We could discuss the latter after we fix the former. I've since tried the cygwin-w32 and mingw64 builds on a different machine, where both builds succeed (however the two machines may have dfferent sets of packages installed in each environment). AndyM