From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: New warnings on emacs-26 branch with gcc 8.2.0 Date: Wed, 15 Aug 2018 16:53:43 +0100 Message-ID: References: <86a7q0ai2z.fsf@gmail.com> <6d36dc4c-1e14-b6c8-e2f0-911d08f759e1@cs.ucla.edu> <83in4os01j.fsf@gnu.org> <16f2754a-b40e-4bc4-f95a-9bada460d5a4@cs.ucla.edu> <83bma9mh3z.fsf@gnu.org> <86eff52njj.fsf@gmail.com> <83wosxkwfz.fsf@gnu.org> <864lg1rlp0.fsf@gmail.com> <83mutslt8f.fsf@gnu.org> <86in4gixg3.fsf@gmail.com> <83d0uolpxt.fsf@gnu.org> <86600giwct.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534362908 21710 195.159.176.226 (15 Aug 2018 19:55:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2018 19:55:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 15 21:55:04 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq1sl-0005Wl-KH for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2018 21:55:03 +0200 Original-Received: from localhost ([::1]:51661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fq1us-0006YR-07 for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2018 15:57:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fq1tN-00063O-1Z for emacs-devel@gnu.org; Wed, 15 Aug 2018 15:55:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fq1tH-0002QE-R9 for emacs-devel@gnu.org; Wed, 15 Aug 2018 15:55:40 -0400 Original-Received: from [195.159.176.226] (port=51952 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fpy7X-0002Kh-Jm for emacs-devel@gnu.org; Wed, 15 Aug 2018 11:55:00 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fpy5D-0000Nw-KO for emacs-devel@gnu.org; Wed, 15 Aug 2018 17:51:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:hkEovplaTwRaiVcvEHN1Opk4w5o= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228570 Archived-At: On Sat 11 Aug 2018, Paul Eggert wrote: > Andy Moreton wrote: >> Given how many source files are involved, for emacs-26 the simplest >> thing is simply to disable -Wcast-function-type in configure.ac. >> >> For master we can leave the warning enabled if the GetProcAddress calls >> can be fixed to pacify the warning. > > If we disable the warning at all, we should do so only in the files that need > it, as the warning is typically useful. I have posted a patch for master to pacify gcc: http://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00451.html Eli has indicated that something like this is too intrusive for emacs-26: http://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00351.html I agree that the warning is useful, but only if genuine warnings are visible amid a large number of false positives. AndyM