From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: master 326fff4: Improve w32notify notifications
Date: Tue, 29 Mar 2016 15:31:38 +0100 [thread overview]
Message-ID: <vz1k2klfj91.fsf@gmail.com> (raw)
In-Reply-To: CAFgFV9OU000qzO_ty16xdpTWYGS_SJ7tk-QRC0hgK2tf3xhojQ@mail.gmail.com
On Mon 21 Mar 2016, Fabrice Popineau wrote:
> 2016-03-19 16:11 GMT+01:00 Michael Albinus <michael.albinus@gmx.de>:
>>
>> I'm curious why you need the additional `read-event' calls. The
>> following `file-notify--wait-for-events' loops until the condition is
>> satisfied, calling `read-event' every iteration.
>>
> Oh ... sorry, yes, we should revert those read-event calls then.
> I added them mechanically, overlooking the macro.
>
> Fabrice
Hi Fabrice,
The master 326fff4 commit also broke the cygwin w32 (i.e. non-X11)
build. The following trivial patch fixes it.
AndyM
diff --git a/src/w32xfns.c b/src/w32xfns.c
index 9b633c4..9a10bf3 100644
--- a/src/w32xfns.c
+++ b/src/w32xfns.c
@@ -48,6 +48,7 @@ init_crit (void)
when the input queue is empty, so make it a manual reset event. */
input_available = CreateEvent (NULL, TRUE, FALSE, NULL);
+#if HAVE_W32NOTIFY
/* Initialize the linked list of notifications sets that will be
used to communicate between the watching worker threads and the
main thread. */
@@ -60,6 +61,7 @@ init_crit (void)
}
else
DebPrint(("Out of memory: can't initialize notifications sets."));
+#endif /* HAVE_W32NOTIFY */
#ifdef WINDOWSNT
keyboard_handle = input_available;
@@ -90,6 +92,7 @@ delete_crit (void)
interrupt_handle = NULL;
}
+#if HAVE_W32NOTIFY
if (notifications_set_head)
{
/* Free any remaining notifications set that could be left over. */
@@ -104,6 +107,7 @@ delete_crit (void)
}
}
free (notifications_set_head);
+#endif /* HAVE_W32NOTIFY */
}
void
next prev parent reply other threads:[~2016-03-29 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160319124618.27869.30424@vcs.savannah.gnu.org>
[not found] ` <E1ahGGo-0007GB-7z@vcs.savannah.gnu.org>
2016-03-19 15:11 ` master 326fff4: Improve w32notify notifications Michael Albinus
2016-03-21 6:03 ` Fabrice Popineau
2016-03-22 10:15 ` Michael Albinus
[not found] ` <CAFgFV9OKWebjGRHrhysG+PCJuQH2vke8eYMbvr05ocQnscMVJg@mail.gmail.com>
[not found] ` <87shzgqbd8.fsf@gmx.de>
[not found] ` <CAFgFV9PE_zRF+ukD9X=k4pYogBEmB9cr=HRA0wig8yZXhgG8Jw@mail.gmail.com>
2016-03-24 13:16 ` Michael Albinus
2016-03-24 15:57 ` Eli Zaretskii
2016-03-24 17:36 ` Michael Albinus
2016-03-29 14:31 ` Andy Moreton [this message]
2016-04-02 9:41 ` Eli Zaretskii
2016-04-02 19:52 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1k2klfj91.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.