From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Replace XChar2b with unsigned in all font backends
Date: Mon, 20 May 2019 13:05:17 +0100 [thread overview]
Message-ID: <vz1k1ell4aq.fsf@gmail.com> (raw)
In-Reply-To: ce05ea8e-6e95-2030-212f-3f15a54f56d0@gmx.at
On Mon 20 May 2019, martin rudalics wrote:
> After this commit, building master on Windows here produces
>
> CC w32term.o
> ../../src/w32font.c: In function 'w32font_draw':
> ../../src/w32font.c:708:25: warning: passing argument 6 of 'ExtTextOutW' from incompatible pointer type [-Wincompatible-pointer-types]
> s->char2b + from + i, 1, NULL);
> ~~~~~~~~~~~~~~~~~^~~
> In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/windows.h:71,
> from ../../src/w32font.c:20:
> C:/msys64/mingw64/x86_64-w64-mingw32/include/wingdi.h:3347:100: note: expected 'LPCWSTR' {aka 'const short unsigned int *'} but argument is of type 'unsigned int *'
> WINGDIAPI WINBOOL WINAPI ExtTextOutW(HDC hdc,int x,int y,UINT options,CONST RECT *lprect,LPCWSTR lpString,UINT c,CONST INT *lpDx);
> ~~~~~~~~^~~~~~~~
> ../../src/w32font.c:711:57: warning: passing argument 6 of 'ExtTextOutW' from incompatible pointer type [-Wincompatible-pointer-types]
> ExtTextOutW (s->hdc, x, y, options, NULL, s->char2b + from, len, NULL);
> ~~~~~~~~~~^~~~~~
> In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/windows.h:71,
> from ../../src/w32font.c:20:
> C:/msys64/mingw64/x86_64-w64-mingw32/include/wingdi.h:3347:100: note: expected 'LPCWSTR' {aka 'const short unsigned int *'} but argument is of type 'unsigned int *'
> WINGDIAPI WINBOOL WINAPI ExtTextOutW(HDC hdc,int x,int y,UINT options,CONST RECT *lprect,LPCWSTR lpString,UINT c,CONST INT *lpDx);
> ~~~~~~~~^~~~~~~~
> CC w32xfns.o
>
> and the resulting build is not usable.
>
> martin
Confirmed. This patch replaces use of XChar2b (a 16bit type) with
unsigned (usually 32bit) which seems wrong.
AndyM
next prev parent reply other threads:[~2019-05-20 12:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 8:26 Replace XChar2b with unsigned in all font backends martin rudalics
2019-05-20 12:05 ` Andy Moreton [this message]
2019-05-20 18:14 ` Alex Gramiak
2019-05-20 18:29 ` Andy Moreton
2019-05-20 19:20 ` Eli Zaretskii
2019-05-20 22:52 ` Andy Moreton
2019-05-21 8:00 ` Eli Zaretskii
2019-05-21 11:50 ` Andy Moreton
2019-05-21 12:38 ` Eli Zaretskii
2019-05-20 19:34 ` Alex Gramiak
2019-05-20 18:07 ` Alex Gramiak
2019-05-21 7:33 ` martin rudalics
2019-05-21 21:32 ` Alex Gramiak
2019-05-21 23:04 ` Andy Moreton
2019-05-22 8:30 ` martin rudalics
2019-05-21 11:47 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1k1ell4aq.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.