From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Windows mingw64 and cygwin builds broken Date: Fri, 13 Nov 2015 11:23:23 +0000 Message-ID: References: <867flnrnhg.fsf@gmail.com> <83y4e3gdbb.fsf@gnu.org> <86y4e2rhom.fsf@gmail.com> <86lha2ir6v.fsf@gmail.com> <837flmgt6g.fsf@gnu.org> <86egfuz0dy.fsf@gmail.com> <83twoqfbwf.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447413848 20426 80.91.229.3 (13 Nov 2015 11:24:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Nov 2015 11:24:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 13 12:23:59 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZxCSV-0004uR-JU for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2015 12:23:59 +0100 Original-Received: from localhost ([::1]:52315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxCSV-0003fC-09 for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2015 06:23:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxCSG-0003dJ-M4 for emacs-devel@gnu.org; Fri, 13 Nov 2015 06:23:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxCSB-0003oP-PC for emacs-devel@gnu.org; Fri, 13 Nov 2015 06:23:44 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:37373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxCSB-0003nm-Hf for emacs-devel@gnu.org; Fri, 13 Nov 2015 06:23:39 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZxCS9-0004Vg-8k for emacs-devel@gnu.org; Fri, 13 Nov 2015 12:23:37 +0100 Original-Received: from uk.solarflare.com ([193.34.186.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Nov 2015 12:23:37 +0100 Original-Received: from andrewjmoreton by uk.solarflare.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Nov 2015 12:23:37 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 51 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: uk.solarflare.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5.50 (windows-nt) Cancel-Lock: sha1:0dmwl5UFES4CUAwLjulzdPyihnU= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194347 Archived-At: On Fri 13 Nov 2015, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Fri, 13 Nov 2015 09:58:33 +0000 >> >> >> ./dbusbind.c:1704: DEFSYM (QCdbus_timeout, ":timeout"); >> >> ./w32fns.c:9302: DEFSYM (QCtimeout, ":timeout"); >> > >> > Does this mean that your MinGW64 build uses D-Bus? If so, it >> > shouldn't use the native w32 tray notifications. I've pushed a change >> > to that effect, please test. If you can afford testing MinGW64 also >> > without D-Bus, I'd appreciate that. >> >> I dont use D-Bus, but it may be detected by configure in the mingw64 >> build. > > Is HAVE_DBUS defined in src/config.h? Is src/dbusbind.c compiled, and > do you see src/dbusbind.o in your MinGW64 build? configure was detecting dbus support (shown in the summary at the end), so I think it was being compiled in. mingw64 bootstrap of commit 2b4c0c0cefa4 works after adding "--without-dbus" to my build script. [ backtracce snipped] > Can you convert this to human-readable backtrace, or run the same > command under GDB and show a backtrace? Sorry, I don't have that build any more. I will look again at the weekend. >> >> Renaming QCdbus_timeout to QCtimeout allows the cygwin-w32 and mingw64 >> >> builds to bootstrap successfully (I don't know if that is the right >> >> fix though). Should the other keyword argument symbols in dbusbind.c >> >> also be renamed QCdbus_* -> QC* ? >> > >> > I don't understand why dbusbind.c uses such a non-standard naming >> > convention. Michael? >> >> If the patch renamed the C symbols to use the normal convention, then it >> appears that there is no harm in havng two modules declare identical >> symbols in syms_of_*(). > > Yes, but I still want to understand the reasons for this naming > convention, and I think we need to avoid calling DEFSYM twice even for > the same name. If we want to avoid calling DEFSYM twice (which seems a good idea), then the C level sumbol names should be available in a header, and common keyword argument symbols should be DEFSYMed in a module that is always present regardless of build options. AndyM