From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken. Date: Mon, 15 Apr 2019 16:32:39 +0100 Message-ID: References: <20190228202146.GC4686@ACM> <20190228205955.GD4686@ACM> <20190410162203.GA4009@ACM> <20190410194525.GB4009@ACM> <52731970482b0b4d53b89d8f187bcc2a.squirrel@dancol.org> <6097cd59-0a23-d063-091b-5bef92904a36@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153632"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 15 17:33:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hG3by-000dre-UX for ged-emacs-devel@m.gmane.org; Mon, 15 Apr 2019 17:33:35 +0200 Original-Received: from localhost ([127.0.0.1]:51789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG3bx-00059z-V8 for ged-emacs-devel@m.gmane.org; Mon, 15 Apr 2019 11:33:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG3bG-00057K-8X for emacs-devel@gnu.org; Mon, 15 Apr 2019 11:32:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG3bF-0002nn-3O for emacs-devel@gnu.org; Mon, 15 Apr 2019 11:32:50 -0400 Original-Received: from [195.159.176.226] (port=39186 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hG3bE-0002mY-Q7 for emacs-devel@gnu.org; Mon, 15 Apr 2019 11:32:49 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hG3bB-000cnG-9o for emacs-devel@gnu.org; Mon, 15 Apr 2019 17:32:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:C0n+v56JT5B+QLcwj6P1vSplPD4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235487 Archived-At: On Mon 15 Apr 2019, Andy Moreton wrote: > On Wed 10 Apr 2019, Paul Eggert wrote: > >> Daniel Colascione wrote: >>> What would make the hashes easier to deal with? Some make target for >>> updating them automatically? An easier way to disable the check at >>> configure time? Transformation into a prominent runtime warning instead of >>> a build break? >> >> It's better to have the build break than to have a runtime check. Of the two >> other approaches you mentioned, I think a configure-time option is the better >> idea. Since these hashes are aimed at developers and are are not needed for >> ordinary builds from tarballs, I think the hashes should be checked on >> request. I resurrected the hashes by installing the attached patch and they >> are now checked with the longstanding 'configure' option --enable-checking=all >> or with the new 'configure' option --enable-checking=structs. Comments welcome >> as usual. > > This newly resurrected checking is already broken on master, which does > not build with confgiure option "--enable-checking=yes,glyphs". > > The struct fingerprint checking should default to enabled (as before) > with the configure arguments allowing it to be (temporarily) disabled. Apologies - the problem is actually in commit 5c2f94a182 ("Replace executable’s fingerprint in place"): CCLD temacs.exe C:\emacs\git\emacs\master\build\mingw64-x86_64\lib-src\make-fingerprint.exe: Error: temacs.exe.tmp is not a regular file make[1]: *** [Makefile:644: temacs.exe] Error 1 make[1]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64/src' make: *** [Makefile:423: src] Error 2 I expect this is something involving the libc handling for Windows builds, as the fstat() call reports st.mode as 0 rather than continaing the expected 0x8000 bit for a regular file. AndyM