From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken.
Date: Mon, 15 Apr 2019 16:32:39 +0100 [thread overview]
Message-ID: <vz1ftqjjnc8.fsf@gmail.com> (raw)
In-Reply-To: vz1k1fvjvhk.fsf@gmail.com
On Mon 15 Apr 2019, Andy Moreton wrote:
> On Wed 10 Apr 2019, Paul Eggert wrote:
>
>> Daniel Colascione wrote:
>>> What would make the hashes easier to deal with? Some make target for
>>> updating them automatically? An easier way to disable the check at
>>> configure time? Transformation into a prominent runtime warning instead of
>>> a build break?
>>
>> It's better to have the build break than to have a runtime check. Of the two
>> other approaches you mentioned, I think a configure-time option is the better
>> idea. Since these hashes are aimed at developers and are are not needed for
>> ordinary builds from tarballs, I think the hashes should be checked on
>> request. I resurrected the hashes by installing the attached patch and they
>> are now checked with the longstanding 'configure' option --enable-checking=all
>> or with the new 'configure' option --enable-checking=structs. Comments welcome
>> as usual.
>
> This newly resurrected checking is already broken on master, which does
> not build with confgiure option "--enable-checking=yes,glyphs".
>
> The struct fingerprint checking should default to enabled (as before)
> with the configure arguments allowing it to be (temporarily) disabled.
Apologies - the problem is actually in commit 5c2f94a182 ("Replace
executable’s fingerprint in place"):
CCLD temacs.exe
C:\emacs\git\emacs\master\build\mingw64-x86_64\lib-src\make-fingerprint.exe: Error: temacs.exe.tmp is not a regular file
make[1]: *** [Makefile:644: temacs.exe] Error 1
make[1]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64/src'
make: *** [Makefile:423: src] Error 2
I expect this is something involving the libc handling for Windows
builds, as the fstat() call reports st.mode as 0 rather than continaing
the expected 0x8000 bit for a regular file.
AndyM
next prev parent reply other threads:[~2019-04-15 15:32 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 20:21 CHECK_STRUCTS/dmpstruct.h mechanism is broken Alan Mackenzie
2019-02-28 20:55 ` Eli Zaretskii
2019-02-28 20:59 ` Alan Mackenzie
2019-03-01 7:31 ` Eli Zaretskii
2019-03-01 13:09 ` Alan Mackenzie
2019-03-05 2:17 ` Paul Eggert
2019-04-09 22:47 ` Paul Eggert
2019-04-10 13:12 ` Andy Moreton
2019-04-10 14:59 ` Andy Moreton
2019-04-10 17:36 ` Paul Eggert
2019-04-10 19:26 ` Andy Moreton
2019-04-10 19:43 ` Daniel Colascione
2019-04-10 16:22 ` Alan Mackenzie
2019-04-10 18:05 ` Paul Eggert
2019-04-10 19:45 ` Alan Mackenzie
2019-04-10 20:11 ` Daniel Colascione
2019-04-11 4:11 ` Paul Eggert
2019-04-15 12:36 ` Andy Moreton
2019-04-15 15:32 ` Andy Moreton [this message]
2019-04-15 15:53 ` Paul Eggert
2019-04-11 13:13 ` Stefan Monnier
2019-04-11 4:17 ` Paul Eggert
2019-04-10 18:47 ` Daniel Colascione
2019-04-10 18:58 ` Paul Eggert
2019-04-10 19:02 ` Daniel Colascione
2019-04-10 19:22 ` Eli Zaretskii
2019-04-11 9:35 ` Robert Pluim
2019-04-11 18:31 ` Paul Eggert
2019-04-11 19:15 ` Eli Zaretskii
2019-04-11 22:13 ` Daniel Colascione
2019-04-12 6:44 ` Eli Zaretskii
2019-04-11 22:23 ` Paul Eggert
2019-04-11 22:26 ` Daniel Colascione
2019-04-11 22:38 ` Paul Eggert
2019-04-12 6:39 ` Eli Zaretskii
2019-04-12 19:40 ` Paul Eggert
2019-04-13 9:36 ` Eli Zaretskii
2019-04-14 2:52 ` Paul Eggert
2019-04-12 12:21 ` Andy Moreton
2019-04-12 13:37 ` Alan Mackenzie
2019-04-12 13:55 ` Eli Zaretskii
2019-04-12 13:58 ` Noam Postavsky
2019-04-13 14:06 ` Alan Mackenzie
2019-04-13 14:46 ` About ./configure --cache-file (WAS: CHECK_STRUCTS/dmpstruct.h mechanism is broken.) Noam Postavsky
2019-04-14 2:44 ` Paul Eggert
2019-04-14 3:26 ` Daniel Colascione
2019-04-14 3:49 ` Noam Postavsky
2019-04-14 9:45 ` Alan Mackenzie
2019-04-14 14:08 ` Eli Zaretskii
2019-04-14 14:44 ` Noam Postavsky
2019-04-14 14:53 ` Eli Zaretskii
2019-04-13 8:11 ` CHECK_STRUCTS/dmpstruct.h mechanism is broken Achim Gratz
2019-04-14 2:52 ` Paul Eggert
2019-04-14 3:28 ` Daniel Colascione
2019-04-14 7:22 ` Achim Gratz
2019-04-14 23:29 ` Paul Eggert
2019-04-15 11:31 ` Alan Mackenzie
2019-04-15 14:14 ` Paul Eggert
2019-04-15 18:11 ` Richard Stallman
2019-04-16 18:10 ` Paul Eggert
2019-04-22 2:18 ` Richard Stallman
2019-04-22 4:07 ` Paul Eggert
2019-04-23 1:41 ` Richard Stallman
2019-04-23 3:48 ` Paul Eggert
2019-04-23 6:25 ` Eli Zaretskii
2019-04-23 16:28 ` Paul Eggert
2019-04-23 17:08 ` Eli Zaretskii
2019-04-23 17:19 ` Stefan Monnier
2019-04-24 2:26 ` Richard Stallman
2019-04-15 3:36 ` Richard Stallman
2019-04-15 5:30 ` Paul Eggert
2019-04-11 19:55 ` Achim Gratz
2019-04-11 22:10 ` Daniel Colascione
2019-04-11 22:47 ` Paul Eggert
2019-04-11 22:44 ` Paul Eggert
2019-04-12 17:02 ` Daniele Nicolodi
2019-04-13 8:26 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1ftqjjnc8.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.