From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: New warnings on emacs-26 branch with gcc 8.2.0 Date: Fri, 17 Aug 2018 16:21:24 +0100 Message-ID: References: <86a7q0ai2z.fsf@gmail.com> <6d36dc4c-1e14-b6c8-e2f0-911d08f759e1@cs.ucla.edu> <83in4os01j.fsf@gnu.org> <16f2754a-b40e-4bc4-f95a-9bada460d5a4@cs.ucla.edu> <83bma9mh3z.fsf@gnu.org> <86eff52njj.fsf@gmail.com> <83wosxkwfz.fsf@gnu.org> <864lg1rlp0.fsf@gmail.com> <83mutslt8f.fsf@gnu.org> <86in4gixg3.fsf@gmail.com> <83d0uolpxt.fsf@gnu.org> <86600giwct.fsf@gmail.com> <861sb4iv2d.fsf@gmail.com> <838t5clnxk.fsf@gnu.org> <838t55gj2q.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534520649 29194 195.159.176.226 (17 Aug 2018 15:44:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2018 15:44:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 17:44:04 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqguw-0007Pd-6p for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2018 17:44:02 +0200 Original-Received: from localhost ([::1]:34858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqgx2-0007gw-Kk for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2018 11:46:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqgZG-0005BQ-9C for emacs-devel@gnu.org; Fri, 17 Aug 2018 11:21:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqgZD-0003Sm-0I for emacs-devel@gnu.org; Fri, 17 Aug 2018 11:21:38 -0400 Original-Received: from [195.159.176.226] (port=43045 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fqgZC-0003RC-PI for emacs-devel@gnu.org; Fri, 17 Aug 2018 11:21:34 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fqgX1-000057-4V for emacs-devel@gnu.org; Fri, 17 Aug 2018 17:19:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 38 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:GL8Mn4UJO8625gkOSRhzhhMCqGQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228643 Archived-At: On Fri 17 Aug 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Tue, 14 Aug 2018 13:59:08 +0100 >> >> The attached patch fixes the -Wcast-function-type warnings when building >> on Windows MSYS2 64bit (GCC 8.2.0) with "-Og". Theere is one remaining >> compiler warning: >> >> C:/emacs/git/emacs/master/src/w32fns.c: In function 'Fw32_read_registry': >> C:/emacs/git/emacs/master/src/w32fns.c:10142:21: warning: 'rootkey' may be used uninitialized in this function [-Wmaybe-uninitialized] >> Lisp_Object val = w32_read_registry (NILP (root) >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> ? HKEY_CURRENT_USER >> ~~~~~~~~~~~~~~~~~~~ >> : rootkey, >> ~~~~~~~~~~ >> key, name); >> ~~~~~~~~~~ > > Thanks, pushed to the master branch. I just made the new function's > name a bit shorter. Thanks. The warning shown above can be fixed with this patch: diff --git a/src/w32fns.c b/src/w32fns.c index c32868fa69..0ad5575e6f 100644 --- a/src/w32fns.c +++ b/src/w32fns.c @@ -10125,7 +10125,7 @@ to be converted to forward slashes by the caller. */) CHECK_STRING (key); CHECK_STRING (name); - HKEY rootkey; + HKEY rootkey UNINIT; if (EQ (root, QHKCR)) rootkey = HKEY_CLASSES_ROOT; else if (EQ (root, QHKCU))