From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Tue, 07 Aug 2018 12:22:21 +0100 Message-ID: References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> <87ftzrknyg.fsf@tromey.com> <87bmaeltcz.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533641121 14244 195.159.176.226 (7 Aug 2018 11:25:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2018 11:25:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 07 13:25:17 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fn073-0003cc-4B for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2018 13:25:17 +0200 Original-Received: from localhost ([::1]:38525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fn099-0000km-QM for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2018 07:27:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fn094-0000kh-14 for emacs-devel@gnu.org; Tue, 07 Aug 2018 07:27:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fn090-0004aw-Rd for emacs-devel@gnu.org; Tue, 07 Aug 2018 07:27:22 -0400 Original-Received: from [195.159.176.226] (port=35383 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fn090-0004ZP-JC for emacs-devel@gnu.org; Tue, 07 Aug 2018 07:27:18 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fn06r-0003OI-9w for emacs-devel@gnu.org; Tue, 07 Aug 2018 13:25:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:BukSoxi0rw/07Vgayc7YDmYfGAE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228266 Archived-At: On Mon 06 Aug 2018, Tom Tromey wrote: >>>>>> "Paul" == Paul Eggert writes: > > Paul> Tom Tromey wrote: >>> So, if Eli or Paul can let me know what they want, I can do it. > > Paul> I prefer consistent names in the new version, even if they don't match > Paul> the old names. I suggest C names like INTEGERP, XINTEGER, FIXNUMP, > Paul> XFIXNUM, BIGNUMP, and XBIGNUM, where 'integer' is the disjoint union > Paul> of 'fixnum' and 'bignum'. Although this consistency will cost us a bit > Paul> in the short run (due to renaming) and even in the long run (due to > Paul> 'git diff' output being longer), it's worth it to keep the code > Paul> readable. > > Seems reasonable to me. The branch is partway there already (as noted); > but maybe all that's left is to rename XINT and XFASTINT. So, XFIXNUM > and XFASTFIXNUM? XFASTINT should be XFIXNAT, as the matching predicate is FIXNATP. AndyM