From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: gnulib strftime imported into Emacs
Date: Mon, 31 Jan 2011 11:32:08 +0000 [thread overview]
Message-ID: <vz1aaihtikn.fsf@gmail.com> (raw)
In-Reply-To: 4D466C8D.2020102@cs.ucla.edu
On Mon 31 Jan 2011, Paul Eggert wrote:
> On 01/30/2011 08:00 PM, Eli Zaretskii wrote:
>
>> Could we please talk before making such disruptive changes in the
>> future?
>
> We did talk; for example,
> <http://lists.gnu.org/archive/html/emacs-devel/2011-01/msg01025.html>.
> I thought this was enough, but apparently I was mistaken.
That discussion seems to be an agreement in principle, not a concrete
set of changes. It would help if you published the actual patch, or a
location where it may be found, together with a description of the
change. This allows changes to be reviewed before they break the build.
>> Ideally, Windows related changes should be committed to the
>> repository at approximately the same time as the changes for Posix
>> platforms, but that's only possible if you let me see the changes
>> _before_ they are committed, and if we coordinate the commit to happen
>> when I have time to work on that. Is such cooperation possible?
>
> I worry that this would mean that every time I want to make a
> nontrivial change to a makefile, I would have to run the exact change
> by you first. And, as you say, you don't have much free time, and can't be
> expected to respond quickly; it might need to wait until the next weekend,
> say. That wouldn't be a good recipe for development; it would slow things
> down too much on the trunk.
While the desire to avoid a slowdown is entirely reasonable, there is
another more important principle in any software development: do not
break the build. It happens occasionally due to an overlooked issue or a
bug, but it should never be done knowingly.
Your current approach is lilely to leave the Win32 build broken more
often than not, which is unhelpful.
> If this turns into a continuing problem, perhaps it would be better to establish
> a branch for Microsoft-related platforms, and to merge changes from the trunk
> into that branch whenever you have time. People could then do Microsoft builds
> from that branch.
The Win32 does not need a separate branch as it is not diverging from
the main tree. It does need a little cooperation from developers on
POSIX systems to ensure that changes are coordinated where possible.
>> It also means that Tom will have to wait for yet another week with his
>> threading related changes
>
> Sorry, I don't get the connection. Tom can't put in his threading
> related changes until Emacs builds on Microsoft platforms?
There is no point integrating a change that breaks the build if the build
is already broken...
AndyM
next prev parent reply other threads:[~2011-01-31 11:32 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 23:43 gnulib strftime imported into Emacs Paul Eggert
2011-01-31 4:00 ` Eli Zaretskii
2011-01-31 8:02 ` Paul Eggert
2011-01-31 9:44 ` joakim
2011-01-31 9:59 ` Miles Bader
2011-01-31 10:16 ` joakim
2011-01-31 10:31 ` Miles Bader
2011-01-31 11:27 ` Eli Zaretskii
2011-01-31 11:06 ` Eli Zaretskii
2011-01-31 14:30 ` Tom Tromey
2011-01-31 14:43 ` Eli Zaretskii
2011-01-31 19:49 ` Eli Zaretskii
2011-01-31 22:19 ` Paul Eggert
2011-01-31 22:29 ` Lennart Borgman
2011-01-31 23:57 ` Paul Eggert
2011-02-01 0:15 ` Lennart Borgman
2011-02-01 0:24 ` Paul Eggert
2011-02-01 0:34 ` Lennart Borgman
2011-02-01 4:05 ` Eli Zaretskii
2011-02-01 7:08 ` Paul Eggert
2011-02-01 8:58 ` Avoiding slowdown in trunk development (was: gnulib strftime imported into Emacs) Eli Zaretskii
2011-02-01 19:04 ` Avoiding slowdown in trunk development Paul Eggert
2011-02-01 19:54 ` Lennart Borgman
2011-02-01 19:57 ` Eli Zaretskii
2011-02-02 16:52 ` Chong Yidong
2011-01-31 11:17 ` gnulib strftime imported into Emacs Lennart Borgman
2011-01-31 11:37 ` Eli Zaretskii
2011-01-31 11:52 ` Lennart Borgman
2011-01-31 13:01 ` Eli Zaretskii
2011-01-31 13:17 ` Andreas Schwab
2011-01-31 14:44 ` Eli Zaretskii
2011-01-31 14:54 ` Andreas Schwab
2011-01-31 15:14 ` Eli Zaretskii
2011-01-31 13:18 ` Lennart Borgman
2011-01-31 14:45 ` Eli Zaretskii
2011-01-31 19:50 ` Eli Zaretskii
2011-01-31 11:32 ` Andy Moreton [this message]
2011-01-31 19:53 ` Eli Zaretskii
2011-01-31 14:56 ` Eli Zaretskii
2011-01-31 16:56 ` Stefan Monnier
2011-01-31 20:06 ` Eli Zaretskii
2011-01-31 20:42 ` Stefan Monnier
2011-01-31 19:54 ` Eli Zaretskii
2011-01-31 23:25 ` Paul Eggert
2011-02-01 4:07 ` Eli Zaretskii
2011-02-01 6:25 ` Paul Eggert
2011-02-01 8:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vz1aaihtikn.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.