From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame. Date: Mon, 06 Aug 2012 10:01:06 +0100 Message-ID: References: <87boiocy9r.fsf@gnu.org> <501F81BE.3000604@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344243703 9122 80.91.229.3 (6 Aug 2012 09:01:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Aug 2012 09:01:43 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 06 11:01:42 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyJC1-0006Lu-Nv for ged-emacs-devel@m.gmane.org; Mon, 06 Aug 2012 11:01:41 +0200 Original-Received: from localhost ([::1]:39537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyJC0-0004Tk-Vm for ged-emacs-devel@m.gmane.org; Mon, 06 Aug 2012 05:01:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyJBt-0004Sz-5j for emacs-devel@gnu.org; Mon, 06 Aug 2012 05:01:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyJBp-0002e0-4r for emacs-devel@gnu.org; Mon, 06 Aug 2012 05:01:33 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:42708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyJBo-0002bw-U1 for emacs-devel@gnu.org; Mon, 06 Aug 2012 05:01:29 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SyJBl-000688-Ad for emacs-devel@gnu.org; Mon, 06 Aug 2012 11:01:25 +0200 Original-Received: from uk.solarflare.com ([193.34.186.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Aug 2012 11:01:25 +0200 Original-Received: from andrewjmoreton by uk.solarflare.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Aug 2012 11:01:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 35 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: uk.solarflare.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (windows-nt) Cancel-Lock: sha1:7RgW5qzoaiVMDE/DLggfaLI9zu4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152209 Archived-At: On Mon 06 Aug 2012, Dmitry Antipov wrote: > On 08/06/2012 10:47 AM, Bastien wrote: > >> This change completely breaks my Emacs. To reproduce: >> >> emacs -Q >> C-h v line-spacing RET >> >> => hangs forever, yells weird sounds, etc. >> >> line-spacing is just an example here, any variable is fine. > > Argh, sorry for breaking the things. Should be fixed in 109463. > > Dmitry Your changes in r109456 also broke the Windows build: gcc -I. -c -gdwarf-2 -g3 -DEMACSDEBUG -fno-crossjumping -IC:/emacs/devel/libxml2-2.7.8/include/libxml2 -IC:/emacs/devel/gnutls-3.0.21/i nclude -IC:/emacs/devel/giflib-4.1.4-1/include -IC:/emacs/devel/jpeg-6b-4/include -IC:/emacs/devel/tiff-3.8.2-1/include -IC:/emacs/devel/ libpng-1.4.3-1/include -IC:/emacs/devel/xpm-3.5.1-1/include -IC:/emacs/devel/xpm-3.5.1-1/src/xpm/3.5.1/libXpm-3.5.1-src/lib -IC:/emacs/de vel/zlib-1.2.5-2/include -Demacs=1 -I../lib -I../nt/inc -DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -DPURESIZE=5000000 -o oo/i386/w32term.o w32term.c w32term.c: In function 'x_frame_rehighlight': w32term.c:2975:49: error: lvalue required as left operand of assignment w32term.c: In function 'x_scroll_bar_create': w32term.c:3647:3: error: lvalue required as left operand of assignment w32term.c: In function 'w32_condemn_scroll_bars': w32term.c:3832:33: error: lvalue required as left operand of assignment w32term.c:3837:43: error: lvalue required as left operand of assignment w32term.c: In function 'w32_redeem_scroll_bar': w32term.c:3868:41: error: lvalue required as left operand of assignment w32term.c:3882:3: error: lvalue required as left operand of assignment w32term.c: In function 'w32_judge_scroll_bars': w32term.c:3899:35: error: lvalue required as left operand of assignment AndyM