From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Why does make run git? Date: Wed, 16 Aug 2017 13:30:12 +0100 Message-ID: References: <83bmo00yw7.fsf@gnu.org> <6d947774-836a-7286-4214-ddc5f516577f@cs.ucla.edu> <87bmngnccv.fsf@lifelogs.com> <87zib0lqdo.fsf@lifelogs.com> <7a270049-7aec-6b99-2a88-06379548b339@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502886659 22183 195.159.176.226 (16 Aug 2017 12:30:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Aug 2017 12:30:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 16 14:30:50 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxTA-00050C-JY for ged-emacs-devel@m.gmane.org; Wed, 16 Aug 2017 14:30:44 +0200 Original-Received: from localhost ([::1]:43193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhxTH-0001Xj-1A for ged-emacs-devel@m.gmane.org; Wed, 16 Aug 2017 08:30:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhxT6-0001Vs-VS for emacs-devel@gnu.org; Wed, 16 Aug 2017 08:30:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhxT3-000814-S9 for emacs-devel@gnu.org; Wed, 16 Aug 2017 08:30:40 -0400 Original-Received: from [195.159.176.226] (port=52977 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhxT3-0007zo-GP for emacs-devel@gnu.org; Wed, 16 Aug 2017 08:30:37 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dhxSq-00041l-3U for emacs-devel@gnu.org; Wed, 16 Aug 2017 14:30:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:mt4elK3+nVAD+v2PFgibW0Hwyk4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217585 Archived-At: On Tue 15 Aug 2017, Paul Eggert wrote: > Ted Zlatanov wrote: > >> I think CONTRIBUTE should mention, right after saying to run autogen.sh, >> that the above requires Git to be installed. > > autogen.sh is not supposed to require Git, so let's fix autogen.sh instead. > > >> 'build-aux/git-hooks/commit-msg' -> '.git/hooks/commit-msg' >> cp: cannot create regular file '.git/hooks/commit-msg': No such file or directory >> ERROR: Job failed: exit code 1 >> #+end_src >> >> So it looks like it assumes that `.git/hooks' exists. I don't know why >> that's not true in the GitLab checkout. > > I don't know why either. I wonder what other compatibility mines remain > unexploded in the GitLab field? Anyway, I installed the attached, which should > work around this particular problem without having to complicate the > configuration instructions. Is it possible that gitlab is using git worktrees, in which case .git in the worktree is a regular file and not a directory ? See the DETAILS section of the git-worktree manpage for an example. AndyM