From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#23771: Eliminating compiler warnings Date: Wed, 22 Jun 2016 15:04:39 +0100 Message-ID: References: <08ec82d8-305e-5a95-7fbb-76162a49f5cc@cornell.edu> <83bn32eclh.fsf@gnu.org> <3f178870-9b99-8104-cb34-1967790436a5@cornell.edu> <5769E61B.9020200@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466604456 18992 80.91.229.3 (22 Jun 2016 14:07:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jun 2016 14:07:36 +0000 (UTC) To: 23771@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 22 16:07:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFioE-00039W-O9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Jun 2016 16:07:14 +0200 Original-Received: from localhost ([::1]:58656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFioE-0004ZA-0I for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Jun 2016 10:07:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFio8-0004Yq-Ev for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 10:07:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFio2-0001Ar-Dl for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 10:07:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFio2-0001Ai-9q for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFio2-0003c0-5b for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 10:07:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <08ec82d8-305e-5a95-7fbb-76162a49f5cc@cornell.edu> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jun 2016 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23771 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.146660438113822 (code B ref -1); Wed, 22 Jun 2016 14:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Jun 2016 14:06:21 +0000 Original-Received: from localhost ([127.0.0.1]:51249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFinN-0003as-8S for submit@debbugs.gnu.org; Wed, 22 Jun 2016 10:06:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFinM-0003ag-3F for submit@debbugs.gnu.org; Wed, 22 Jun 2016 10:06:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFinB-00011L-TJ for submit@debbugs.gnu.org; Wed, 22 Jun 2016 10:06:14 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFinB-000119-Pv for submit@debbugs.gnu.org; Wed, 22 Jun 2016 10:06:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFin4-000471-Vv for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 10:06:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFimy-0000zs-KU for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 10:06:01 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:40754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFimy-0000y0-D8 for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 10:05:56 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bFimN-0001B5-V5 for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 16:05:20 +0200 Original-Received: from uk.solarflare.com ([193.34.186.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 Jun 2016 16:05:19 +0200 Original-Received: from andrewjmoreton by uk.solarflare.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 Jun 2016 16:05:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: uk.solarflare.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (windows-nt) Cancel-Lock: sha1:aVOVbCoI3w5xzYnUc6nx3I6LNTk= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119929 Archived-At: On Wed 22 Jun 2016, Paul Eggert wrote: > Thanks for all the work in improving static checking for Cygwin builds. I just > now checked the attached patch into master, which I hope improves on it. I > tested it on Fedora (both with and without window systems). > > I had one problem with the recent changes, in that they suppressed all > warnings about jumps over AUTO_STRING calls. That's pretty drastic, as the > warnings are typically useful, so the attached patch reverts that. Can you let > me know which call needs the warning suppressed in the Cygwin-specific code in > the new master? I can suggest something which disables the warning just for > that call. Your patch changed FRAME_INTERNAL_BORDER_WIDTH() from a macro to an inline function, which breaks the mingw64 build: ../../src/w32fns.c: In function 'x_set_internal_border_width': ../../src/w32fns.c:1661:39: error: lvalue required as left operand of assignment FRAME_INTERNAL_BORDER_WIDTH (f) = border; ^ With FRAME_INTERNAL_BORDER_WIDTH() as a macro, it builds successfully. AndyM