* bug#20455: elisp-completion-at-point not compatible replacement for lisp-completion-at-point
@ 2015-04-29 6:57 Glenn Morris
2015-04-29 11:11 ` Dmitry Gutov
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2015-04-29 6:57 UTC (permalink / raw)
To: 20455
Package: emacs
Version: 25.0.50
In Emacs 24.5:
(lisp-completion-at-point &optional PREDICATE)
; PREDICATE is unused, but I don't see that this affects the following
In current master:
lisp-completion-at-point is an alias for `elisp-completion-at-point'.
But elisp-completion-at-point takes no arguments.
Therefore this is an incompatible change.
This is presumably why attempting to use lisp-complete-symbol throws a
wrong-number-of-arguments error.
(Why doesn't the byte-compiler warn about this arglist mismatch?)
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#20455: elisp-completion-at-point not compatible replacement for lisp-completion-at-point
2015-04-29 6:57 bug#20455: elisp-completion-at-point not compatible replacement for lisp-completion-at-point Glenn Morris
@ 2015-04-29 11:11 ` Dmitry Gutov
2015-04-29 15:50 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Gutov @ 2015-04-29 11:11 UTC (permalink / raw)
To: Glenn Morris, 20455
On 04/29/2015 09:57 AM, Glenn Morris wrote:
> This is presumably why attempting to use lisp-complete-symbol throws a
> wrong-number-of-arguments error.
Can we remove it? It has already been declared obsolete in a previous
version.
> (Why doesn't the byte-compiler warn about this arglist mismatch?)
It does here:
In lisp-complete-symbol:
lisp.el:754:17:Warning: lisp-completion-at-point called with 1 argument, but
accepts only 0
lisp.el:754:17:Warning: `lisp-completion-at-point' is an obsolete
function (as
of 25.1); use `elisp-completion-at-point' instead.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#20455: elisp-completion-at-point not compatible replacement for lisp-completion-at-point
2015-04-29 11:11 ` Dmitry Gutov
@ 2015-04-29 15:50 ` Glenn Morris
2015-04-29 21:17 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2015-04-29 15:50 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 20455
Dmitry Gutov wrote:
> Can we remove it? It has already been declared obsolete in a previous
> version.
Too soon IMO.
The trivial solution: make elisp-completion-at-point take an optional
arg that does nothing. Or don't make lisp-completion-at-point an alias
to it.
>> (Why doesn't the byte-compiler warn about this arglist mismatch?)
>
> It does here:
>
> In lisp-complete-symbol:
> lisp.el:754:17:Warning: lisp-completion-at-point called with 1 argument, but
> accepts only 0
> lisp.el:754:17:Warning: `lisp-completion-at-point' is an obsolete
> function (as
> of 25.1); use `elisp-completion-at-point' instead.
I filed a separate bug about that; but for the record, no such warning
when bootstrapping for me nor, for eg
http://hydra.nixos.org/build/21790217/log/raw
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#20455: elisp-completion-at-point not compatible replacement for lisp-completion-at-point
2015-04-29 15:50 ` Glenn Morris
@ 2015-04-29 21:17 ` Stefan Monnier
2015-11-30 3:29 ` Dmitry Gutov
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2015-04-29 21:17 UTC (permalink / raw)
To: Glenn Morris; +Cc: Dmitry Gutov, 20455
> arg that does nothing. Or don't make lisp-completion-at-point an alias
> to it.
Exactly, make it into a wrapper,
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#20455: elisp-completion-at-point not compatible replacement for lisp-completion-at-point
2015-04-29 21:17 ` Stefan Monnier
@ 2015-11-30 3:29 ` Dmitry Gutov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Gutov @ 2015-11-30 3:29 UTC (permalink / raw)
To: Stefan Monnier, Glenn Morris; +Cc: 20455-done
Version: 25.1
On 04/30/2015 12:17 AM, Stefan Monnier wrote:
> Exactly, make it into a wrapper,
Done, in 50b8c55.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-30 3:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-29 6:57 bug#20455: elisp-completion-at-point not compatible replacement for lisp-completion-at-point Glenn Morris
2015-04-29 11:11 ` Dmitry Gutov
2015-04-29 15:50 ` Glenn Morris
2015-04-29 21:17 ` Stefan Monnier
2015-11-30 3:29 ` Dmitry Gutov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.