From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthieu Moy Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#4201: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem) Date: Wed, 19 Aug 2009 15:41:01 +0200 Message-ID: References: Reply-To: Matthieu Moy , 4201@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250803164 12006 80.91.229.12 (20 Aug 2009 21:19:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Aug 2009 21:19:24 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 20 23:19:17 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MeF2R-0007nx-TK for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 23:19:16 +0200 Original-Received: from localhost ([127.0.0.1]:41647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeF2R-0007b3-8F for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 17:19:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeF2N-0007ay-LY for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:19:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeF2J-0007af-1u for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:19:10 -0400 Original-Received: from [199.232.76.173] (port=58761 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeF2I-0007ac-Qu for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:19:06 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:52315) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeF2I-0007El-Bo for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:19:06 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7KKkpoi019227; Thu, 20 Aug 2009 13:48:05 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7KKYot4016766; Thu, 20 Aug 2009 13:34:50 -0700 Resent-Date: Thu, 20 Aug 2009 13:34:50 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Matthieu Moy Original-Sender: Matthieu Moy Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 20 Aug 2009 20:34:49 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 4201 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125068927612359 (code B ref -1); Thu, 20 Aug 2009 20:34:49 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 19 Aug 2009 13:41:16 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7JDfF6v012356 for ; Wed, 19 Aug 2009 06:41:16 -0700 Original-Received: from mx10.gnu.org ([199.232.76.166]:35638) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MdlPe-0000Gc-MS for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:14 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MdlPc-0000em-C4 for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:14 -0400 Original-Received: from mx2.imag.fr ([129.88.30.17]:50505 helo=rominette.imag.fr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MdlPa-0000dr-IB for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:11 -0400 Original-Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by rominette.imag.fr (8.13.8/8.13.8) with ESMTP id n7JDdYhr006476 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 19 Aug 2009 15:39:34 +0200 Original-Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1MdlPR-0003vt-7D; Wed, 19 Aug 2009 15:41:01 +0200 Original-Received: from moy by bauges.imag.fr with local (Exim 4.63) (envelope-from ) id 1MdlPR-00072W-5n; Wed, 19 Aug 2009 15:41:01 +0200 In-Reply-To: (Matthieu Moy's message of "Wed\, 19 Aug 2009 14\:21\:05 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.91 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (rominette.imag.fr [129.88.30.17]); Wed, 19 Aug 2009 15:39:34 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: n7JDdYhr006476 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: moy@imag.fr MailScanner-NULL-Check: 1251293976.91015@qUS2RIomKKohcMPpbcrb5Q X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 20 Aug 2009 17:19:10 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30374 gmane.emacs.pretest.bugs:24970 Archived-At: Matthieu Moy writes: > Fine, I thought, my dbus is too old, I don't need it, I'll disable it. > But compiling with --without-dbus, it doesn't work either: > > Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc > Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el > Loading tramp... > > In toplevel form: > ../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus > make[2]: *** [...] Error 1 This happens since this revision below (thanks to 'git bisect' ;-) ). Reverting it fixes the problem for me. I guess the important part was the (when (and (featurep 'dbusbind) (not (featurep 'dbus))) which got lost in the process. commit f1a6beaaeea05ae21131f38ed5ff243046fb29f2 Author: Michael Albinus Date: Wed Aug 19 07:08:57 2009 +0000 * net/dbus.el (top): Apply `dbus-init-bus' for the :session bus only if it is running already. diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el index c1222a6..159fcb6 100644 --- a/lisp/net/dbus.el +++ b/lisp/net/dbus.el @@ -41,15 +41,6 @@ (defvar dbus-debug) (defvar dbus-registered-functions-table) -;; Initialize :system and :session buses. This adds their file -;; descriptors to input_wait_mask, in order to detect incoming -;; messages immediately. -;; We must avoid to call the function twice for a bus, because the -;; DBusWatch will be removed then. -(when (and (featurep 'dbusbind) (not (featurep 'dbus))) - (dbus-init-bus :system) - (dbus-init-bus :session)) - ;; Pacify byte compiler. (eval-when-compile (require 'cl)) @@ -841,6 +832,14 @@ name of the property, and its value. If there are no properties, (cons property (dbus-get-property bus service path interface property)) 'append))))) +;; Initialize :system and :session buses. This adds their file +;; descriptors to input_wait_mask, in order to detect incoming +;; messages immediately. +(dbus-ignore-errors + (dbus-init-bus :system) + (when (getenv "DBUS_SESSION_BUS_ADDRESS") + (dbus-init-bus :session))) + (provide 'dbus) ;; arch-tag: a47caf84-9162-4811-90cc-5d388e37b9bd -- Matthieu