From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: emacs-pretest-bug@gnu.org
Subject: bug#4201: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
Date: Wed, 19 Aug 2009 15:41:01 +0200 [thread overview]
Message-ID: <vpqr5v7ncpe.fsf@bauges.imag.fr> (raw)
In-Reply-To: <vpqy6pgngem.fsf@bauges.imag.fr> (Matthieu Moy's message of "Wed\, 19 Aug 2009 14\:21\:05 +0200")
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
> Fine, I thought, my dbus is too old, I don't need it, I'll disable it.
> But compiling with --without-dbus, it doesn't work either:
>
> Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc
> Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el
> Loading tramp...
>
> In toplevel form:
> ../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus
> make[2]: *** [...] Error 1
This happens since this revision below (thanks to 'git bisect' ;-) ).
Reverting it fixes the problem for me. I guess the important part was
the
(when (and (featurep 'dbusbind) (not (featurep 'dbus)))
which got lost in the process.
commit f1a6beaaeea05ae21131f38ed5ff243046fb29f2
Author: Michael Albinus <michael.albinus@gmx.de>
Date: Wed Aug 19 07:08:57 2009 +0000
* net/dbus.el (top): Apply `dbus-init-bus' for the :session bus
only if it is running already.
diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el
index c1222a6..159fcb6 100644
--- a/lisp/net/dbus.el
+++ b/lisp/net/dbus.el
@@ -41,15 +41,6 @@
(defvar dbus-debug)
(defvar dbus-registered-functions-table)
-;; Initialize :system and :session buses. This adds their file
-;; descriptors to input_wait_mask, in order to detect incoming
-;; messages immediately.
-;; We must avoid to call the function twice for a bus, because the
-;; DBusWatch will be removed then.
-(when (and (featurep 'dbusbind) (not (featurep 'dbus)))
- (dbus-init-bus :system)
- (dbus-init-bus :session))
-
;; Pacify byte compiler.
(eval-when-compile
(require 'cl))
@@ -841,6 +832,14 @@ name of the property, and its value. If there are no properties,
(cons property (dbus-get-property bus service path interface property))
'append)))))
+;; Initialize :system and :session buses. This adds their file
+;; descriptors to input_wait_mask, in order to detect incoming
+;; messages immediately.
+(dbus-ignore-errors
+ (dbus-init-bus :system)
+ (when (getenv "DBUS_SESSION_BUS_ADDRESS")
+ (dbus-init-bus :session)))
+
(provide 'dbus)
;; arch-tag: a47caf84-9162-4811-90cc-5d388e37b9bd
--
Matthieu
next prev parent reply other threads:[~2009-08-19 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <nqws4xo8a7.fsf@alcatel-lucent.de>
2009-08-19 12:21 ` bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem) Matthieu Moy
2009-08-19 13:41 ` Matthieu Moy [this message]
2009-08-21 9:00 ` bug#4201: marked as done (23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)) Emacs bug Tracking System
2009-08-21 9:00 ` bug#4186: " Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqr5v7ncpe.fsf@bauges.imag.fr \
--to=matthieu.moy@imag.fr \
--cc=4201@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.