From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#5950: defvaralias after defvar should be warned in runtime Date: Wed, 15 Sep 2010 16:16:03 -0400 Message-ID: References: <4BC6A096.8030801@yahoo.co.jp> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1284583246 1652 80.91.229.12 (15 Sep 2010 20:40:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 15 Sep 2010 20:40:46 +0000 (UTC) Cc: 5950@debbugs.gnu.org To: IRIE Shinsuke Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 15 22:40:44 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ovyma-0000PO-5C for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Sep 2010 22:40:44 +0200 Original-Received: from localhost ([127.0.0.1]:57156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvymZ-0005Wf-Ft for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Sep 2010 16:40:43 -0400 Original-Received: from [140.186.70.92] (port=38464 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvymT-0005V5-5k for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2010 16:40:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvymR-0007Y9-Rr for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2010 16:40:37 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47190) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvymR-0007Y3-MU for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2010 16:40:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OvyMk-0005Mk-GB; Wed, 15 Sep 2010 16:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Sep 2010 20:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5950-submit@debbugs.gnu.org id=B5950.128458161320617 (code B ref 5950); Wed, 15 Sep 2010 20:14:02 +0000 Original-Received: (at 5950) by debbugs.gnu.org; 15 Sep 2010 20:13:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvyMG-0005MU-MQ for submit@debbugs.gnu.org; Wed, 15 Sep 2010 16:13:32 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvyME-0005MP-KW for 5950@debbugs.gnu.org; Wed, 15 Sep 2010 16:13:31 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OvyOh-0000G9-Tv; Wed, 15 Sep 2010 16:16:03 -0400 X-Spook: White Water nitrate Uzi brigand e-bomb covert video X-Ran: yY@l@pG>(>Lo0uU2AdMd~3Bjr~a%ni/sg2,$KQf9Gy'zx:aWg__}wxl:I=3G|3o*TKK?w% X-Hue: green X-Attribution: GM In-Reply-To: <4BC6A096.8030801@yahoo.co.jp> (IRIE Shinsuke's message of "Thu\, 15 Apr 2010 14\:13\:58 +0900") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 15 Sep 2010 16:14:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40190 Archived-At: IRIE Shinsuke wrote: > We assume an user wrote .emacs file as: > > (setq old-foo 123) > (load "bar") > > Here, bar.el includes the following: > > (defvar foo 456) > (define-obsolete-variable-alias 'old-foo 'foo) > > By this .emacs setting, the user probably hopes `old-foo' remains 123 > after loading bar.el, but actually it will be changed to 456. [...] > I think the programs like bar.el should be warned when running (and > byte-compiling, if possible). You can never have too many compilation warnings... Here is an attempt at this. Comments: 1) It gives a spurious warning in cases where the define-obsolete-variable-alias statement is autoloaded. One could simply reposition such statements anyway. 2) I never know when to use normal-call or keep-pending. It does reveal a couple of bugs in the current trunk. *** lisp/emacs-lisp/bytecomp.el 2010-09-15 15:30:43 +0000 --- lisp/emacs-lisp/bytecomp.el 2010-09-15 18:59:50 +0000 *************** *** 3874,3879 **** --- 3874,3892 ---- (byte-compile-set-symbol-position 'lambda) (error "`lambda' used as function name is invalid")) + (put 'define-obsolete-variable-alias 'byte-hunk-handler + 'byte-compile-define-obsolete-variable-alias) + ;; Gives a spurious warning if the d-o-v-a is autoloaded. + (defun byte-compile-define-obsolete-variable-alias (form) + (and (byte-compile-warning-enabled-p 'suspicious) + (eq (car-safe (nth 2 form)) 'quote) + (memq (car-safe (cdr (nth 2 form))) byte-compile-bound-variables) + (not (memq (cadr (nth 2 form)) byte-compile-const-variables)) + (byte-compile-warn "variable `%s' aliased after definition" + (cadr (nth 2 form)))) + (byte-compile-keep-pending form) + nil) + ;; Compile normally, but deal with warnings for the function being defined. (put 'defalias 'byte-hunk-handler 'byte-compile-file-form-defalias) (defun byte-compile-file-form-defalias (form)