From: Mitchel Humpherys <mitch.special@gmail.com>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Overlay modification-hooks no longer running after 564d811725 (under certain configurations)
Date: Thu, 10 Dec 2015 15:52:34 -0800 [thread overview]
Message-ID: <vnkwh9jpamkd.fsf@gmail.com> (raw)
Hello,
I noticed recently that iedit [1] stopped working on the emacs-25 and
master branches. I finally got around to git bisect'ing it today and
found that the breaking commit is:
commit 564d811725596f15ecf543777e11504b47d2af86
Author: Eli Zaretskii <eliz@gnu.org>
Date: Fri Nov 6 17:19:39 2015 +0200
Don't invoke overlay modification hooks in wrong buffer
The relevant iedit code seems to be:
(overlay-put occurrence 'insert-in-front-hooks '(iedit-occurrence-update-hook))
(overlay-put occurrence 'insert-behind-hooks '(iedit-occurrence-update-hook))
(overlay-put occurrence 'modification-hooks '(iedit-occurrence-update-hook))
(from [2]). If I revert the commit above on the emacs-25 tip (or
checkout that commit's parent), the hook does run and iedit works as
expected.
I apologize for not filing a bug, but I don't have an `emacs -Q' recipe,
so there must be some other interaction with my config going on, which I
haven't tracked down... It's also possible that iedit is incorrectly
relying on some broken behavior.
I was hoping someone might have an idea of what's going on here. If
not, I'll continue pursuing a smaller repro recipe.
[1] https://github.com/victorhge/iedit
[2] https://github.com/victorhge/iedit/blob/master/iedit-lib.el#L287
--
Mitch
next reply other threads:[~2015-12-10 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 23:52 Mitchel Humpherys [this message]
2015-12-11 7:50 ` Overlay modification-hooks no longer running after 564d811725 (under certain configurations) Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vnkwh9jpamkd.fsf@gmail.com \
--to=mitch.special@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.