all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: [alinsoar@voila.fr: EVAL and mouse selection in *Completions*]
Date: Mon, 05 Mar 2007 21:50:27 -0500	[thread overview]
Message-ID: <vld53ngk5o.fsf@fencepost.gnu.org> (raw)
In-Reply-To: E1HOL4x-0005f5-OI@fencepost.gnu.org

Richard Stallman wrote:

> Would someone please fix this, then ack?
>
> From: A Soare <alinsoar@voila.fr>
> Subject: EVAL and mouse selection in *Completions*

This bug was already mentioned by Martin Rudalics in reply to your
mail "[bojohan+mail@bogus.example.com: Partial completion]" of Feb
24th. 

I suggest the following fix, but it seems both this bug and the other
one need input from the OPs (or those who use partial completion), to
test that the suggested fixes do not break anything else.


***************
*** 710,722 ****
  			(and completion-auto-help
  			     (eq last-command this-command))
  			(eq mode 'help))
  		    (with-output-to-temp-buffer "*Completions*"
  		      (display-completion-list (sort helpposs 'string-lessp))
  		      (with-current-buffer standard-output
  			;; Record which part of the buffer we are completing
  			;; so that choosing a completion from the list
  			;; knows how much old text to replace.
! 			(setq completion-base-size dirlength)))
  		  (PC-temp-minibuffer-message " [Next char not unique]"))
  		nil)))))
  
--- 718,734 ----
  			(and completion-auto-help
  			     (eq last-command this-command))
  			(eq mode 'help))
+                     (let ((width (minibuffer-prompt-width)))
                        (with-output-to-temp-buffer "*Completions*"
                          (display-completion-list (sort helpposs 'string-lessp))
                          (with-current-buffer standard-output
                            ;; Record which part of the buffer we are completing
                            ;; so that choosing a completion from the list
                            ;; knows how much old text to replace.
!                           (setq completion-base-size
!                                 (if dirname
!                                     dirlength
!                                   (- beg 1 width))))))
                    (PC-temp-minibuffer-message " [Next char not unique]"))
  		nil)))))

  reply	other threads:[~2007-03-06  2:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05 21:50 [alinsoar@voila.fr: EVAL and mouse selection in *Completions*] Richard Stallman
2007-03-06  2:50 ` Glenn Morris [this message]
2007-03-06  3:12   ` Chong Yidong
2007-03-06  3:22   ` Nick Roberts
2007-03-06  3:57     ` Glenn Morris
2007-03-06  3:59       ` Glenn Morris
2007-03-06  9:10         ` martin rudalics
2007-03-06 14:45           ` Stefan Monnier
2007-03-07  4:35           ` Glenn Morris
2007-03-07 10:24             ` martin rudalics
2007-03-08  9:28               ` Glenn Morris
2007-03-06 22:36   ` Richard Stallman
2007-03-07  4:22     ` Glenn Morris
2007-03-07 17:26       ` Richard Stallman
2007-03-07 18:35         ` Stefan Monnier
2007-03-08 17:40           ` Richard Stallman
2007-03-08 19:07             ` Stefan Monnier
2007-03-09 21:27               ` Richard Stallman
  -- strict thread matches above, loose matches on Subject: below --
2007-03-06  9:57 A Soare
2007-03-08  8:28 A Soare
2007-03-08  8:41 ` Nick Roberts
2007-03-08 21:47 ` Richard Stallman
2007-03-08  8:31 A Soare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vld53ngk5o.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.