From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Coding conventions (was: [Patch] Make tls.el support certificate verification) Date: Wed, 28 Nov 2007 23:08:29 +0100 Message-ID: References: <877imqtdhb.fsf@denkblock.local> <87zlzc35bh.fsf@mocca.josefsson.org> <87ps063ixd.fsf@mocca.josefsson.org> <87zlxo4lwr.fsf@denkblock.local> <87d4uaksur.fsf@denkblock.local> <877ikhlrgs.fsf@denkblock.local> <871wacrlj9.fsf@denkblock.local> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196287795 8501 80.91.229.12 (28 Nov 2007 22:09:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Nov 2007 22:09:55 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Elias Oltmanns Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 28 23:10:00 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IxV6B-0008HM-Ft for ged-emacs-devel@m.gmane.org; Wed, 28 Nov 2007 23:09:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IxV5v-0007Ec-Rh for ged-emacs-devel@m.gmane.org; Wed, 28 Nov 2007 17:09:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IxV5j-00074t-IN for emacs-devel@gnu.org; Wed, 28 Nov 2007 17:09:11 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IxV5i-00074F-Rx for emacs-devel@gnu.org; Wed, 28 Nov 2007 17:09:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IxV5i-000741-JZ for emacs-devel@gnu.org; Wed, 28 Nov 2007 17:09:10 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IxV5i-0004tW-4L for emacs-devel@gnu.org; Wed, 28 Nov 2007 17:09:10 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.1/8.14.1) with ESMTP id lASM95Yf007816; Wed, 28 Nov 2007 23:09:05 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 5995A12DB6; Wed, 28 Nov 2007 23:09:05 +0100 (CET) X-Face: mtjf/D:es1T0wHO:&CJ'ZXe"l; 3C--rw\z!{`eFwL){|]RpI+4{u25L=5C /0>KuGeTsk<~<&NE-AKV1560e!+RJeyWmSskkrJm?[vUV#66{T_m|Ae<||Ku#Mk5`y&O`n~z2; n8eP J5#2h@2eQgV@E70IY_0WlEx!"&giy{+\%h1LJox$zv@/l%ZmU4^tZA>xQpnkUBVC5.jpg#0'(+2?Rs )NAr:>3<=WxHE$ktbLysDIM5TbmHu*3, emacs-devel@gnu.org, ding@gnus.org In-Reply-To: <871wacrlj9.fsf@denkblock.local> (Elias Oltmanns's message of "Tue, 27 Nov 2007 12:10:50 +0100") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) X-DCC-dcc.uncw.edu-Metrics: poseidon 1201; Body=3 Fuz1=3 Fuz2=3 X-Virus-Scanned: by amavisd-new X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84262 gmane.emacs.gnus.general:65803 Archived-At: On Tue, Nov 27 2007, Elias Oltmanns wrote: >> See http://article.gmane.org/gmane.emacs.gnus.commits/5529 for my >> cosmetic/style changes. > > In the cvs trunk I can see that you made some adjustments to line breaks > as well. What is the maximum line length in doc strings? The first line should be short enough to fit into an apropos buffer (with a width of 80 columns). As for the other lines, I simply hit M-q (with Emacs' default settings). `M-x checkdoc RET' helps to fix common mistakes for doc string and other style issues. > Also, is there a comprehensive source for information about Emacs > and Gnus codingstyle and good practice? For Gnus: `texi/gnus-coding.texi'. As Gnus is part of Emacs, we try to follow the conventions for Emacs. E.g. (info "(elisp)Tips"), (info "(elisp)Coding Conventions"). I don't think there's a comprehensive source. > And what is the canonical way to provide ChangeLog entries if I have > no commit privileges or, to put it another way, the attached patch > alright in this respect? As the ChangeLog is modified very often, patches usually don't apply properly. Therefore it's better to provide the ChangeLog directly in the message, e.g. ... --8<---------------cut here---------------start------------->8--- 2007-11-27 Elias Oltmanns * tls.el (open-tls-stream): Actually consult tls-checktrust to see if certs should be verified and what is to be done in the event of a verification failure. --8<---------------cut here---------------end--------------->8--- Note that the colon after "tls.el" was not correct. Then the committer can simply Copy&Paste it and adjust the date. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/