From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Thien-Thi Nguyen <ttn@gnuvola.org>
Cc: "Gabor Z. Papp" <gzp@papp.hu>, ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Top posting related changes in the cvs
Date: Wed, 04 Apr 2007 00:05:29 +0200 [thread overview]
Message-ID: <v9slbhnmfq.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <873b3hm942.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Tue\, 03 Apr 2007 23\:38\:37 +0200")
On Tue, Apr 03 2007, Thien-Thi Nguyen wrote:
> before the fix, yanking would leave the cursor after the yanked
> messages, contrary to the docstring. the fix, to regain concordance w/
> the docstring, involves conditionalizing a previously unconditional call
> to exchange-point-and-mark. i believe the original unconditional call
> was correct (necessary) prior to another change:
>
> 2005-08-01 Katsumi Yamaoka <yamaoka@jpl.org>
>
> * gnus-uu.el (gnus-uu-save-article): Use insert-buffer-substring
> instead of insert-buffer.
>
> * message.el (message-yank-original): Ditto; set the mark at the
> end of the yanked message.
>
> insert-buffer-substring inserts before point, while insert-buffer
> inserts after point. my analysis is that the exchange-point-and-mark
> relied on insert-buffer's behavior, and thus became incorrect after the
> 2005-08-01 change, since point and mark were already in the correct
> order.
>
> my fix (to conditionalize the call) removes the direct dependency so
> that the desired ending position of point will be as documented for
> whatever function is used (now or in the future) to do the insert, as
> long as the inserted text is bracketed by point and mark.
>
> an alternative fix that is less robust against future changes is to rely
> on the behavior of insert-buffer-substring and simply remove the call to
> exchange-point-and-mark. then we can chase this bug again later for
> hours of fun...
[...]
> i think the behavior, leaving point between the citation and the yanked
> text, is nice. i was happy to read about it in the docstring. it seems
> whoever wrote the original (concording) code+docstring was thoughtful.
I gather that you refer to an interactive call of
`message-yank-original' (C-c C-y) after doing a reply/followup without
citing the original (using `r'/`f'). However, when using `R'/`F', I
don't get this behavior anymore: Point is _below_ the quote, which is
wrong.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next prev parent reply other threads:[~2007-04-03 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <x6lkh9xt79@gzp>
2007-04-03 20:45 ` Top posting related changes in the cvs Reiner Steib
2007-04-03 21:38 ` Thien-Thi Nguyen
2007-04-03 22:05 ` Reiner Steib [this message]
2007-04-03 23:02 ` Thien-Thi Nguyen
2007-04-03 23:11 ` Gabor Z. Papp
2007-04-09 6:40 ` Katsumi Yamaoka
2007-04-09 18:30 ` Thien-Thi Nguyen
2007-04-09 19:49 ` Reiner Steib
2007-04-09 23:15 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9slbhnmfq.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=gzp@papp.hu \
--cc=ttn@gnuvola.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.