From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: Re: New Emacs facilities from Gnus Date: Fri, 09 Nov 2007 13:14:24 +0100 Message-ID: References: <87zly3y4ru.fsf@catnip.gol.com> <87odejy30k.fsf@catnip.gol.com> <87bqa8z601.fsf@arnested.dk> <87hcjz80jr.fsf@arnested.dk> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1194627448 30505 80.91.229.12 (9 Nov 2007 16:57:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Nov 2007 16:57:28 +0000 (UTC) Cc: Arne =?iso-8859-1?Q?J=F8rgensen?= , Stefan Monnier , rms@gnu.org, emacs-devel@gnu.org To: Sascha Wilde Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 09 17:57:31 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IqXAc-0002L3-0c for ged-emacs-devel@m.gmane.org; Fri, 09 Nov 2007 17:57:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqXAQ-0006a1-HM for ged-emacs-devel@m.gmane.org; Fri, 09 Nov 2007 11:57:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqXAO-0006Zs-9v for emacs-devel@gnu.org; Fri, 09 Nov 2007 11:57:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqXAM-0006Z4-7o for emacs-devel@gnu.org; Fri, 09 Nov 2007 11:57:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqXAM-0006Z1-3o for emacs-devel@gnu.org; Fri, 09 Nov 2007 11:57:10 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IqXAH-00086s-EJ; Fri, 09 Nov 2007 11:57:05 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.1/8.14.1) with ESMTP id lA9Gv2V2006800; Fri, 9 Nov 2007 17:57:02 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 655C012C5B; Fri, 9 Nov 2007 17:57:02 +0100 (CET) X-Face: P05mdcZT&lL[-s2=mw~RsllZ0zZAb?vdE}.s, Stefan Monnier , emacs-devel@gnu.org, rms@gnu.org, Arne =?iso-8859-1?Q?J=F8rgensen?= In-Reply-To: (Sascha Wilde's message of "Fri, 09 Nov 2007 11:45:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-DCC-HP_X86_64_8CPU-Metrics: poseidon 1245; Body=5 Fuz1=5 Fuz2=5 X-Virus-Scanned: by amavisd-new X-MIME-Autoconverted: from 8bit to quoted-printable by mail.uni-ulm.de id lA9Gv2V2006800 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82878 Archived-At: On Fri, Nov 09 2007, Sascha Wilde wrote: > Stefan Monnier wrote: >>> + (if (or (featurep 'xemacs) >>> + ;; For Emacs >=3D 22 we don't need smime-ldap.el >>> + (>=3D emacs-major-version 22)) Correction: =A0 (< emacs-major-version 22) >>> + (progn >>> + (require 'smime-ldap) > [...] >> Those kinds of test qualify as "yucky" in my book. I guess you mean the version check? Yes, I don't like it, but I can't think of a better test in this case. >> I'd rather do >> >> (ignore-errors (require 'smime-ldap))=20 This would unnecessarily load and use smime-ldap in Emacs 22+ e.g. when using the standalone Gnus distribution (or if smime-ldap.el is present in load-path). >> and then (fboundp 'smime-ldap-search). > Emacs 22 require has an optional argument NOERROR, so=20 > (require 'smime-ldap nil t)=20 > would be safe (and one can use the return value). But I don't know if > it is portable... XEmacs 21.4 doesn't have it, IIRC. Bye, Reiner. --=20 ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/