From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; tool bar icons disappear in customize buffers Date: Fri, 04 Jan 2008 14:31:47 +0100 Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1199453583 10134 80.91.229.12 (4 Jan 2008 13:33:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Jan 2008 13:33:03 +0000 (UTC) Cc: Chong Yidong To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 04 14:33:22 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JAmfo-0005JA-E8 for ged-emacs-devel@m.gmane.org; Fri, 04 Jan 2008 14:33:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAmfR-0004mJ-Fo for ged-emacs-devel@m.gmane.org; Fri, 04 Jan 2008 08:32:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAmf4-0004SW-NR for emacs-devel@gnu.org; Fri, 04 Jan 2008 08:32:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAmf3-0004RK-Pc for emacs-devel@gnu.org; Fri, 04 Jan 2008 08:32:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAmf3-0004R0-Fa for emacs-devel@gnu.org; Fri, 04 Jan 2008 08:32:33 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAmf2-0000vO-Uc for emacs-devel@gnu.org; Fri, 04 Jan 2008 08:32:33 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m04DWSwD028852; Fri, 4 Jan 2008 14:32:28 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 0E1BA12DD3; Fri, 4 Jan 2008 14:32:28 +0100 (CET) X-Face: 1; h7XMU[7l}$T@J.D}5z*w8Tg'}B5ArAWc8>2X~otB; kOjKs8X%|hTC#dG:%Vpx")x7S/`v :VXU#fZW$X$zdhEU.RfVQ@<-m9IuN{Hm"fW{,5]6kR'M*vEs+{5Cj!L(JTRzA$(},?5J=sm; %Od In-Reply-To: (Reiner Steib's message of "Sat, 08 Dec 2007 12:56:42 +0100") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-DCC-INFN-TO-Metrics: poseidon 1233; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86062 Archived-At: Hi, I didn't get a response to this in ~4 weeks: On Sat, Dec 08 2007, Reiner Steib wrote: >> Please describe exactly what actions triggered the bug >> and the precise symptoms of the bug: > > emacs -Q > > M-x customize-variable RET savehist-mode RET > > ==> All tool bar icons disappear. The tool bar area and thus the > whole frame shrinks. > > ,----[ v tool-bar-map RET ] > | tool-bar-map is a variable defined in `[...]/emacs/lisp/tool-bar.elc'. > | Its value is shown below. > | > | Documentation: > | Keymap for the tool bar. > | Define this locally to override the global tool bar. > | > | Value: nil > | Local in buffer *Customize Option: Savehist Mode*; global value is > | (keymap > | (new-file menu-item "Visit New File..." find-file > | [...] > `---- > > ,----[ v tool-bar-mode RET ] > | tool-bar-mode is a variable defined in `[...]/emacs/lisp/tool-bar.elc'. > | Its value is t > | > | Documentation: > | Non-nil if Tool-Bar mode is enabled. > | See the command `tool-bar-mode' for a description of this minor mode. > | Setting this variable directly does not take effect; > | either customize it (see the info node `Easy Customization') > | or call the function `tool-bar-mode'. > | > | You can customize this variable. > `---- > > I'd guess that the following changes might be relevant: > > ,----[ lisp/ChangeLog ] > | 2007-07-05 Chong Yidong > | > | * cus-edit.el (custom-commands): New variable. > | (custom-tool-bar-map): New variable. Initialize using > | `custom-commands'. > | (custom-mode): Use `custom-tool-bar-map'. > | [...] > `---- > > Is the following code in `cus-edit.el' correct? Is this code > evaluated at compile time (when `display-graphic-p' returns nil?)? > > (defvar tool-bar-map) > (defvar custom-tool-bar-map > (if (display-graphic-p) > (let ((map (make-sparse-keymap))) > (mapc > (lambda (arg) > (tool-bar-local-item-from-menu > (nth 1 arg) (nth 4 arg) map custom-mode-map)) > custom-commands) > map))) > > [BTW, using `when' would make the code more readable. Shouldn't the > variable have a doc string?] > > ,----[ v custom-tool-bar-map RET ] > | custom-tool-bar-map is a variable defined in `[...]/emacs/lisp/cus-edit.elc'. > | Its value is nil > | > | Documentation: > | Not documented as a variable. > `---- > > The problem doesn't exist neither in Emacs 22.1 nor in EMACS_22_BASE. > >> In GNU Emacs 23.0.50.7 (i686-pc-linux-gnu, GTK+ Version 2.10.6) >> of 2007-12-08 on viandante >> Windowing system distributor `The X.Org Foundation', version 11.0.70199902 >> configured using `configure '--prefix=/import/xtra/emacs/HEAD' >> '--with-gtk' '--exec-prefix=/import/xtra/emacs/HEAD-i686' >> 'CFLAGS=-Wno-pointer-sign -O0 -fno-crossjumping -gdwarf-2 -g3'' > >> Important settings: >> value of $LC_ALL: nil >> value of $LC_COLLATE: nil >> value of $LC_CTYPE: nil >> value of $LC_MESSAGES: nil >> value of $LC_MONETARY: nil >> value of $LC_NUMERIC: nil >> value of $LC_TIME: nil >> value of $LANG: en_US.UTF-8 >> locale-coding-system: utf-8 >> default-enable-multibyte-characters: t > >> Major mode: Custom > >> Minor modes in effect: >> tooltip-mode: t >> tool-bar-mode: t >> mouse-wheel-mode: t >> menu-bar-mode: t >> file-name-shadow-mode: t >> global-font-lock-mode: t >> font-lock-mode: t >> blink-cursor-mode: t >> unify-8859-on-encoding-mode: t >> utf-translate-cjk-mode: t >> auto-compression-mode: t >> line-number-mode: t > >> Recent input: >> M-x c u s t o m i z w e - v a r i a b e >> l l e s a v e h i >> s t - m o d e v t o o l 0 >> - b a r - m a C-x 2 v t o o l - >> b a r - m o d e >> M-x r e p o r > >> Recent messages: >> For information about GNU Emacs and the GNU system, type C-h C-a. >> Creating customization items... >> Loading savehist...done >> Creating customization items ...done >> Resetting customization items...done >> Creating customization setup...done >> Type C-x 1 to delete the help window, C-M-v to scroll help. >> Making completion list...