From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: PCL-CVS menu enhancements Date: Sun, 20 Jan 2008 21:38:18 +0100 Message-ID: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1200861536 391 80.91.229.12 (20 Jan 2008 20:38:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Jan 2008 20:38:56 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 20 21:39:14 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JGgwi-0007WC-Vz for ged-emacs-devel@m.gmane.org; Sun, 20 Jan 2008 21:39:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGgwJ-0001sq-ML for ged-emacs-devel@m.gmane.org; Sun, 20 Jan 2008 15:38:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JGgwF-0001pk-63 for emacs-devel@gnu.org; Sun, 20 Jan 2008 15:38:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JGgwD-0001oK-S9 for emacs-devel@gnu.org; Sun, 20 Jan 2008 15:38:42 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGgwD-0001oB-Nm for emacs-devel@gnu.org; Sun, 20 Jan 2008 15:38:41 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JGgwD-0008M3-He for emacs-devel@gnu.org; Sun, 20 Jan 2008 15:38:41 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m0KKcci3006174; Sun, 20 Jan 2008 21:38:38 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 511BF12DF0; Sun, 20 Jan 2008 21:38:38 +0100 (CET) X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T; w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv, vbL^XF1nIp\:F=$Ei2o&mEe:%N~, :3]vtQ~s9u$9izmX$IF@VgGl7/, ^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Followup-To: Stefan Monnier , emacs-devel@gnu.org User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) X-DCC-CTc-dcc1-Metrics: poseidon 1030; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87128 Archived-At: --=-=-= Hi, I'd like to propose some minor enhancements to PCL-CVS's menu (full patch attached below). | (easy-menu-define cvs-menu cvs-mode-map "Menu used in `cvs-mode'." | '("CVS" | - ["Open file.." cvs-mode-find-file t] | - [" ..other window" cvs-mode-find-file-other-window t] | + ["Open file..." cvs-mode-find-file t] | + [" ...in other window" cvs-mode-find-file-other-window t] | ["Display in other window" cvs-mode-display-file t] | ["Interactive merge" cvs-mode-imerge t] At least for "Open file", the convention is to have three dots, isn't it? Or better like this? ["Open file..." cvs-mode-find-file t] ["Open in other window" cvs-mode-find-file-other-window t] | ["Current diff" cvs-mode-diff t] | ["Diff with head" cvs-mode-diff-head t] | ["Diff with vendor" cvs-mode-diff-vendor t] | + ["Diff against yesterday" cvs-mode-diff-yesterday t] | ["Diff with backup" cvs-mode-diff-backup t]) Why omit `cvs-mode-diff-yesterday'? | ["Hide handled" cvs-mode-remove-handled t] | "----" | + ["PCL-CVS Manual" (lambda () (interactive) | + (info "(pcl-cvs)Top")) t] | + "----" | ["Quit" cvs-mode-quit t])) Users might look in the Emacs manual first. This should make it easier to find the right manual. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- pcvs-defs.el 09 Jan 2008 20:35:45 +0100 1.44 +++ pcvs-defs.el 20 Jan 2008 21:25:28 +0100 @@ -404,8 +404,8 @@ (easy-menu-define cvs-menu cvs-mode-map "Menu used in `cvs-mode'." '("CVS" - ["Open file.." cvs-mode-find-file t] - [" ..other window" cvs-mode-find-file-other-window t] + ["Open file..." cvs-mode-find-file t] + [" ...in other window" cvs-mode-find-file-other-window t] ["Display in other window" cvs-mode-display-file t] ["Interactive merge" cvs-mode-imerge t] ("View diff" @@ -413,6 +413,7 @@ ["Current diff" cvs-mode-diff t] ["Diff with head" cvs-mode-diff-head t] ["Diff with vendor" cvs-mode-diff-vendor t] + ["Diff against yesterday" cvs-mode-diff-yesterday t] ["Diff with backup" cvs-mode-diff-backup t]) ["View log" cvs-mode-log t] ["View status" cvs-mode-status t] @@ -437,6 +438,9 @@ ["Unmark all" cvs-mode-unmark-all-files t] ["Hide handled" cvs-mode-remove-handled t] "----" + ["PCL-CVS Manual" (lambda () (interactive) + (info "(pcl-cvs)Top")) t] + "----" ["Quit" cvs-mode-quit t])) ;;;; --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--