From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: PCL-CVS menu enhancements
Date: Sun, 20 Jan 2008 21:38:18 +0100 [thread overview]
Message-ID: <v9sl0skzb9.fsf@marauder.physik.uni-ulm.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]
Hi,
I'd like to propose some minor enhancements to PCL-CVS's menu (full
patch attached below).
| (easy-menu-define cvs-menu cvs-mode-map "Menu used in `cvs-mode'."
| '("CVS"
| - ["Open file.." cvs-mode-find-file t]
| - [" ..other window" cvs-mode-find-file-other-window t]
| + ["Open file..." cvs-mode-find-file t]
| + [" ...in other window" cvs-mode-find-file-other-window t]
| ["Display in other window" cvs-mode-display-file t]
| ["Interactive merge" cvs-mode-imerge t]
At least for "Open file", the convention is to have three dots, isn't
it?
Or better like this?
["Open file..." cvs-mode-find-file t]
["Open in other window" cvs-mode-find-file-other-window t]
| ["Current diff" cvs-mode-diff t]
| ["Diff with head" cvs-mode-diff-head t]
| ["Diff with vendor" cvs-mode-diff-vendor t]
| + ["Diff against yesterday" cvs-mode-diff-yesterday t]
| ["Diff with backup" cvs-mode-diff-backup t])
Why omit `cvs-mode-diff-yesterday'?
| ["Hide handled" cvs-mode-remove-handled t]
| "----"
| + ["PCL-CVS Manual" (lambda () (interactive)
| + (info "(pcl-cvs)Top")) t]
| + "----"
| ["Quit" cvs-mode-quit t]))
Users might look in the Emacs manual first. This should make it
easier to find the right manual.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1142 bytes --]
--- pcvs-defs.el 09 Jan 2008 20:35:45 +0100 1.44
+++ pcvs-defs.el 20 Jan 2008 21:25:28 +0100
@@ -404,8 +404,8 @@
(easy-menu-define cvs-menu cvs-mode-map "Menu used in `cvs-mode'."
'("CVS"
- ["Open file.." cvs-mode-find-file t]
- [" ..other window" cvs-mode-find-file-other-window t]
+ ["Open file..." cvs-mode-find-file t]
+ [" ...in other window" cvs-mode-find-file-other-window t]
["Display in other window" cvs-mode-display-file t]
["Interactive merge" cvs-mode-imerge t]
("View diff"
@@ -413,6 +413,7 @@
["Current diff" cvs-mode-diff t]
["Diff with head" cvs-mode-diff-head t]
["Diff with vendor" cvs-mode-diff-vendor t]
+ ["Diff against yesterday" cvs-mode-diff-yesterday t]
["Diff with backup" cvs-mode-diff-backup t])
["View log" cvs-mode-log t]
["View status" cvs-mode-status t]
@@ -437,6 +438,9 @@
["Unmark all" cvs-mode-unmark-all-files t]
["Hide handled" cvs-mode-remove-handled t]
"----"
+ ["PCL-CVS Manual" (lambda () (interactive)
+ (info "(pcl-cvs)Top")) t]
+ "----"
["Quit" cvs-mode-quit t]))
;;;;
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next reply other threads:[~2008-01-20 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-20 20:38 Reiner Steib [this message]
2008-01-21 0:12 ` PCL-CVS menu enhancements Stefan Monnier
2008-01-21 23:13 ` Reiner Steib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9sl0skzb9.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.