cp-supported-codepages

cp-supported-codepages

[Glenn Morris]

cp-supported-codepages seems to have been removed from
lisp/international/codepage, but there is no associated ChangeLog or
NEWS entry.

mm-codepage-setup in gnus/mm-util uses it.

Oh, I guess it's:

2008-02-02  Dave Love  <fx@gnu.org>

     * international/codepage.el: Most of code removed or commented out.

Re: cp-supported-codepages

[Glenn Morris]

Glenn Morris wrote:

> cp-supported-codepages seems to have been removed from
> lisp/international/codepage, but there is no associated ChangeLog or
> NEWS entry.
>
> mm-codepage-setup in gnus/mm-util uses it.

Added to FOR-RELEASE.

> Oh, I guess it's:
>
> 2008-02-02  Dave Love  <fx@gnu.org>
>
>      * international/codepage.el: Most of code removed or commented out.

Re: cp-supported-codepages

[Reiner Steib]

On Fri, Feb 08 2008, Glenn Morris wrote:

> Glenn Morris wrote:
>> cp-supported-codepages seems to have been removed from
>> lisp/international/codepage, but there is no associated ChangeLog or
>> NEWS entry.
>>
>> mm-codepage-setup in gnus/mm-util uses it.

`mm-codepage-setup' is a basically a no-op already in Emacs 22 since
we have autoloads for the cpNUMBER and windows-NUMBER coding systems.

> Added to FOR-RELEASE.

How about the following patch?

--8<---------------cut here---------------start------------->8---
--- mm-util.el	02 Feb 2008 11:28:36 +0100	1.67
+++ mm-util.el	08 Feb 2008 23:30:58 +0100	
@@ -219,7 +219,9 @@
 the alias.  Else windows-NUMBER is used."
   (interactive
    (let ((completion-ignore-case t)
-	 (candidates (cp-supported-codepages)))
+	 (candidates (if (fboundp 'cp-supported-codepages)
+			 (cp-supported-codepages)
+		       (error "`codepage-setup' is obsolete in this Emacs version."))))
      (list (completing-read "Setup DOS Codepage: (default 437) " candidates
 			    nil t nil nil "437"))))
   (when alias
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: cp-supported-codepages

[Glenn Morris]

Reiner Steib wrote:

> How about the following patch?

Looks fine for Gnus AFAICS.

Separately, it still seems to me that NEWS entries are needed to
explain what has changed in this regard.

Re: cp-supported-codepages

[Reiner Steib]

On Fri, Feb 08 2008, Glenn Morris wrote:

> Looks fine for Gnus AFAICS.

Installed and modified FOR-RELEASE accordingly.

> Separately, it still seems to me that NEWS entries are needed to
> explain what has changed in this regard.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/