From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: Re: battery.el: Rename display-battery-mode to battery-mode? Date: Thu, 04 Aug 2005 17:54:35 +0200 Message-ID: References: <87pssu42bf.fsf@xs4all.nl> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1123171338 16208 80.91.229.2 (4 Aug 2005 16:02:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 Aug 2005 16:02:18 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 04 18:02:08 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E0i8h-0006tN-Pc for ged-emacs-devel@m.gmane.org; Thu, 04 Aug 2005 18:00:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E0iBV-0006ZH-Rn for ged-emacs-devel@m.gmane.org; Thu, 04 Aug 2005 12:03:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E0iA1-0005vg-Ml for emacs-devel@gnu.org; Thu, 04 Aug 2005 12:01:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E0i9z-0005uA-2i for emacs-devel@gnu.org; Thu, 04 Aug 2005 12:01:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E0i9y-0005pj-An for emacs-devel@gnu.org; Thu, 04 Aug 2005 12:01:30 -0400 Original-Received: from [134.60.1.1] (helo=mail.uni-ulm.de) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1E0iG9-0005ZM-8w for emacs-devel@gnu.org; Thu, 04 Aug 2005 12:07:53 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.3/8.13.3) with ESMTP id j74FsZLf014366; Thu, 4 Aug 2005 17:54:36 +0200 (MEST) Original-Received: by bridgekeeper.physik.uni-ulm.de (Postfix, from userid 170) id A543310957; Thu, 4 Aug 2005 17:54:35 +0200 (CEST) Original-To: Lute Kamstra Mail-Followup-To: Lute Kamstra , emacs-devel@gnu.org X-Face: #vK]N[`vqjuod*|)'[iD7/"3AB-ApT%fmN"LWAg@oS7OesGv~)n[OBTLM#I="J'Y^-7I I/ps7o_'IK@#-Rs{::DZ@O8yS|fexe,XslY[:dNWOb~>?mC-&i_c)say:"\IpA.5U.b]'NY; Pks{lb h.+#6%DpZuaK3dcHB`Av3zc:r!C%~s0&m, tWj]&}, qg.+0ww2gK%f!:GK|wMl.I!(voY*1"^li8"~B BNG)9LvPi?^DMR-GVDnZqhu*3Hi, +g=wFhI)BL6&u{EOVEHjVEVq~d?_}lMntWAc3(6?kftjc>_f>! g0wM(qPM$d5]^TT_Qyi&L?LGVG)SHN;Gk/,pkY9,~ In-Reply-To: <87pssu42bf.fsf@xs4all.nl> (Lute Kamstra's message of "Thu, 04 Aug 2005 08:57:08 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-DCC-WEiAPG-Metrics: gemini 1072; Body=2 Fuz1=2 Fuz2=2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41489 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41489 On Thu, Aug 04 2005, Lute Kamstra wrote: > Reiner Steib writes: > >> I tried to enable battery-mode on my notebook using `M-x battery- >> TAB' but I got "No match". Eventually I found >> `display-battery-mode' in `battery.el'. Shouldn't the name of the >> minor mode read `battery-mode' instead of `display-battery-mode'? > > Agreed. (In the meantime I saw that there's one similarly named (interactive) command `display-time-mode'.) >> +(define-obsolete-function-alias 'display-battery-mode 'battery-mode "22.1") [...] >> Okay to commit? > > Ok with me. > >> Shouldn't battery mode be mentioned briefly in (info "(emacs)Optional >> Mode Line") as well? > > Maybe you can write a patch? --8<---------------cut here---------------start------------->8--- --- display.texi 17 Jul 2005 17:48:14 +0200 1.98 +++ display.texi 04 Aug 2005 17:54:03 +0200 @@ -890,6 +890,11 @@ to specify the directory to check for incoming mail (any nonempty regular file in the directory is considered as ``newly arrived mail''). +@findex battery-mode +On some systems, Emacs can display battery status information in the +mode line. To enable this feature, type @kbd{M-x battery-mode} or +customize the option @code{battery-mode}. + @cindex mode line, 3D appearance @cindex attributes of mode line, changing @cindex non-integral number of lines in a window --8<---------------cut here---------------end--------------->8--- Of course one could describe some related variables (battery-mode-line-format, battery-update-interval, battery-load-low, battery-load-critical), but IIRC the goal is not to add to much text to the manual. Does it make sense to mention `battery-status-function' in the doc strings of `battery' and `[display-]battery-mode'? Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/