From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: Re: Diffs between %s and %s end here Date: Sun, 09 Mar 2008 23:39:55 +0100 Message-ID: References: <18370.47294.641890.556694@kahikatea.snap.net.nz> <18371.9275.720477.806834@kahikatea.snap.net.nz> <2vzltos6g1.fsf@fencepost.gnu.org> <18371.49683.356527.589505@kahikatea.snap.net.nz> <18377.55334.203888.524043@kahikatea.snap.net.nz> <434pbqcaz5.fsf@fencepost.gnu.org> <200803021853.m22IrRvA000730@sallyv1.ics.uci.edu> <200803031858.m23IwToH009344@sallyv1.ics.uci.edu> <200803041839.m24Idmis008291@sallyv1.ics.uci.edu> <200803052150.m25Loonc011429@sallyv1.ics.uci.edu> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205102538 21321 80.91.229.12 (9 Mar 2008 22:42:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 9 Mar 2008 22:42:18 +0000 (UTC) Cc: rgm@gnu.org, nickrob@snap.net.nz, emacs-devel@gnu.org, Juri Linkov , dann@ics.uci.edu, miles@gnu.org To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 09 23:42:45 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JYUE7-000846-7N for ged-emacs-devel@m.gmane.org; Sun, 09 Mar 2008 23:42:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JYUDZ-0005Uy-41 for ged-emacs-devel@m.gmane.org; Sun, 09 Mar 2008 18:42:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JYUBv-0004ms-4R for emacs-devel@gnu.org; Sun, 09 Mar 2008 18:40:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JYUBt-0004mJ-D2 for emacs-devel@gnu.org; Sun, 09 Mar 2008 18:40:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JYUBt-0004mB-7x for emacs-devel@gnu.org; Sun, 09 Mar 2008 18:40:25 -0400 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JYUBi-0007Y2-OT; Sun, 09 Mar 2008 18:40:15 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m29MeBlg000065; Sun, 9 Mar 2008 23:40:11 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 3820012FE7; Sun, 9 Mar 2008 23:40:11 +0100 (CET) X-Face: .*T0'iU(sujq_j9\J>-d4fg; N/1++U#U$_5ii6k.=|"-n'?5O:Hyz&wi'-!I~,}7~GgT=0S /&-R5sbkNy5+Xo1y{Tw2KKxi@Xh"g@]Qc|.U<*]WDd)qvGowFDvfU1F]{EDho:7P0@|oOD=Bc{K4?> WP68K[Mx:}=`ZT'6g4'f+g?;`vri2!)xGy}3:=l'(/Cea0l4lo^H5#@/Z3ev Mail-Followup-To: Richard Stallman , rgm@gnu.org, nickrob@snap.net.nz, dann@ics.uci.edu, emacs-devel@gnu.org, miles@gnu.org, Juri Linkov In-Reply-To: (Richard Stallman's message of "Sun, 09 Mar 2008 16:53:37 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-DCC-URT-Metrics: poseidon 1060; Body=7 Fuz1=7 Fuz2=7 X-Virus-Scanned: by amavisd-new X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91941 Archived-At: On Sun, Mar 09 2008, Richard Stallman wrote: > When I produce a diff before committing a change, I often want to make > sure the no unintended/other changes crept in. I expect to see > exactly the diffs, not some disturbing additional lines. > > How do you check that they are exactly the same diffs? > Do you use M-x compare-windows? No. Usually I just look at it. E.g. when someone sends a mail with a patch for Gnus, I apply it from the mail buffer. Then I do `C-x v =' (or `=' in PCL-CVS) and check if everything is as intended (e.g. that there are no other unrelated uncommitted changes). > When that comes to the end of the diffs in both buffers, the fact > that one has a note saying "end of diffs" won't make it harder for > you to tell that the two are identical. [...] > I don't think that end-of-diffs message will do any harm when you save > or mail the diffs. I can only repeat that even after seeing this note several time, I was still distracted. We already had such a end-of-diff note in CVS (see the subject: "Diffs between %s and %s end here") for some weeks and _nobody_ argued to keep it, but several developers were and still are strongly against it. > Additionally, in > compilation mode, it is more clear that this line is not part of the > output because the bold words are in green or red: > > We could put colors into the notice in the diff buffer just as we do > in compilation mode. I agree with Juri (and others)...; in <87k5kb7pm9.fsf@jurta.org>, Juri wrote: | Then we could use the same non-intrusive solution already implemented for | compile: when compilation is successful it displays the successful status | in the mode line of the compilation buffer in green. When compilation | fails, it displays the error code in the mode line in red. | | So no additional text is necessary to append to the end of the output that | many find too annoying. This modeline indication should be enough for | confirmation the process completed normally. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/