From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: featurep instead of bound tests (was: Changes to emacs/lisp/gnus/ChangeLog, v) Date: Thu, 24 Jan 2008 22:44:37 +0100 Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1201211210 29776 80.91.229.12 (24 Jan 2008 21:46:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jan 2008 21:46:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 24 22:47:08 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JI9uV-0005Fb-Kg for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2008 22:47:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JI9u5-0001zi-Fj for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2008 16:46:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JI9sq-0001WV-8G for emacs-devel@gnu.org; Thu, 24 Jan 2008 16:45:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JI9so-0001Vc-Id for emacs-devel@gnu.org; Thu, 24 Jan 2008 16:45:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JI9so-0001VN-BF for emacs-devel@gnu.org; Thu, 24 Jan 2008 16:45:14 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JI9sn-0000vu-L9 for emacs-devel@gnu.org; Thu, 24 Jan 2008 16:45:14 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m0OLj87i010677; Thu, 24 Jan 2008 22:45:09 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 9DA0B1C4A4; Thu, 24 Jan 2008 22:45:08 +0100 (CET) X-Face: P05mdcZT&lL[-s2=mw~RsllZ0zZAb?vdE}.s, In-Reply-To: (Dan Nicolaescu's message of "Thu, 24 Jan 2008 15:14:59 +0000") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) X-DCC-INFN-TO-Metrics: poseidon 1233; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87453 Archived-At: On Thu, Jan 24 2008, Dan Nicolaescu on emacs-diffs: > --- gnus/ChangeLog 24 Jan 2008 07:47:37 -0000 1.633 > +++ gnus/ChangeLog 24 Jan 2008 15:14:50 -0000 1.634 > @@ -1,3 +1,9 @@ > +2008-01-24 Dan Nicolaescu > + > + * sieve.el (sieve-make-overlay, sieve-overlay-put, sieve-overlays-at): > + * message.el (message-beginning-of-line): Use featurep instead of bound > + tests in order to resolve conditionals at compile time. In the past, I've been told that it's preferable to use fbound tests instead of Emacs flavor or version tests. So I'm surprised by changes like these... > --- gnus/sieve.el 8 Jan 2008 20:45:19 -0000 1.12 > +++ gnus/sieve.el 24 Jan 2008 15:14:49 -0000 1.13 > @@ -290,15 +290,15 @@ > (get-char-property (or pos (point)) 'script-name)) > > (eval-and-compile > - (defalias 'sieve-make-overlay (if (fboundp 'make-overlay) > - 'make-overlay > - 'make-extent)) > - (defalias 'sieve-overlay-put (if (fboundp 'overlay-put) > - 'overlay-put > - 'set-extent-property)) > - (defalias 'sieve-overlays-at (if (fboundp 'overlays-at) > - 'overlays-at > - 'extents-at))) > + (defalias 'sieve-make-overlay (if (featurep 'xemacs) > + 'make-extent > + 'make-overlay)) > + (defalias 'sieve-overlay-put (if (featurep 'xemacs) > + 'set-extent-property > + 'overlay-put)) > + (defalias 'sieve-overlays-at (if (featurep 'xemacs) > + 'extents-at > + 'overlays-at))) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/