From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: hard-newline changes in lisp/gnus/message.el Date: Fri, 18 Nov 2005 18:31:04 +0100 Message-ID: Reply-To: Reiner Steib NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1132335101 8651 80.91.229.6 (18 Nov 2005 17:31:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2005 17:31:41 +0000 (UTC) Cc: Miles Bader , Gnus , Emacs development Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 18 18:31:30 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1EdA5C-0006Xo-00 for ; Fri, 18 Nov 2005 18:31:30 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EdA5B-0002l0-7A for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2005 12:31:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EdA4y-0002kt-7I for emacs-devel@gnu.org; Fri, 18 Nov 2005 12:31:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EdA4w-0002kf-M1 for emacs-devel@gnu.org; Fri, 18 Nov 2005 12:31:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EdA4w-0002kc-J9 for emacs-devel@gnu.org; Fri, 18 Nov 2005 12:31:14 -0500 Original-Received: from [134.60.1.1] (helo=mail.uni-ulm.de) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1EdA4v-00013M-HP; Fri, 18 Nov 2005 12:31:14 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.4/8.13.4) with ESMTP id jAIHV4ej022148; Fri, 18 Nov 2005 18:31:04 +0100 (MET) Original-Received: by bridgekeeper.physik.uni-ulm.de (Postfix, from userid 170) id 7D30210BE0; Fri, 18 Nov 2005 18:31:04 +0100 (CET) Original-To: Chong Yidong Mail-Followup-To: Emacs development , Gnus X-Face: P05mdcZT&lL[-s2=mw~RsllZ0zZAb?vdE}.s List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46240 gmane.emacs.gnus.general:61387 Archived-At: Hi, when changing lisp/gnus/*.el, please keep in mind that this directory is synced by Miles Bader with the (primary) Gnus repository on gnus.org in order to simplify the process of including a new stable Gnus version in Emacs. The stable version of Gnus (the v5-10 branch in Gnus CVS) should be identical[1] to the version in Emacs CVS and it should work with Emacs 20.7 and up and XEmacs 21.1 and up. It would be nice to discuss possibly controversial changes on emacs-devel and ding@gnus.org (Gnus development list) before committing. As for `hard-newline': Obviously `hard-newline' is not defined in Emacs < 22. I'm not sure what's the best way to deal with this. I'd suggest to define `message-hard-newline' in `message.el' as follows and use it instead of `hard-newline'. (defvar message-hard-newline (if (featurep 'xemacs) "\n" ;; Or better code for XEmacs (if (boundp 'hard-newline) hard-newline (propertize "\n" 'hard t 'rear-nonsticky '(hard))))) Or: (defvar message-hard-newline (cond ((boundp 'hard-newline) hard-newline) ((fboundp 'propertize) (propertize "\n" 'hard t 'rear-nonsticky '(hard))) (t "\n"))) BTW, maybe `hard-newline' should have a doc string? Bye, Reiner. [1] Exception: Version number. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/