From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: emacs-devel@gnu.org, ding@gnus.org
Subject: Re: [Patch] Make tls.el support certificate verification
Date: Sat, 24 Nov 2007 22:31:28 +0100 [thread overview]
Message-ID: <v9k5o71gb3.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <877ikhlrgs.fsf@denkblock.local> (Elias Oltmanns's message of "Sat, 17 Nov 2007 00:07:31 +0100")
On Sat, Nov 17 2007, Elias Oltmanns wrote:
> Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>> Sorry for the delay, I didn't have a change do commit your changes
>> during the past week (I'm not at home and I don't have a reasonable
>> internet connection at the moment).
>
> Alright. Thanks for clarifying.
Committed. Thank you for your contributions.
Some remarks for future contributions:
- The ChangeLog entries should be per function / per variable, e.g.:
* tls.el (tls-certtool-program, tls-hostmismatch): New variables.
(tls-checktrust): New variable. Check if GNU TLS complained about a
mismatch between the hostname provided in the certificate and the name
of the host connnecting to.
(open-tls-stream): Use them. Check certificates against trusted root
certificates.
- defcustoms don't need the leading "*" in the doc string. (In many
Emacs lisp files they still exist, but they will be removed
eventually.)
- defcustoms should have a version tag.
See http://article.gmane.org/gmane.emacs.gnus.commits/5529 for my
cosmetic/style changes.
Would it be useful to add the strings suggested in the doc string of
`tls-checktrust' to `tls-program'? Or provide them as custom options
for `tls-program'?
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next prev parent reply other threads:[~2007-11-24 21:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 23:08 [Patch] Make tls.el support certificate verification Elias Oltmanns
2007-09-24 7:12 ` Simon Josefsson
2007-09-24 16:27 ` Reiner Steib
2007-09-25 14:42 ` Simon Josefsson
2007-11-08 18:44 ` Elias Oltmanns
2007-11-08 19:52 ` Reiner Steib
2007-11-16 17:22 ` Elias Oltmanns
2007-11-16 22:38 ` Reiner Steib
2007-11-16 23:07 ` Elias Oltmanns
2007-11-24 21:31 ` Reiner Steib [this message]
2007-11-25 0:35 ` Elias Oltmanns
2007-11-25 14:18 ` Reiner Steib
2007-11-26 14:47 ` Simon Josefsson
2007-11-27 11:10 ` Elias Oltmanns
2007-11-28 22:05 ` Reiner Steib
2007-11-28 22:08 ` Coding conventions (was: [Patch] Make tls.el support certificate verification) Reiner Steib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9k5o71gb3.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=eo@nebensachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.