From: Ted Zlatanov <tzz@lifelogs.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/tzz/auth-source-reveal-mode 4a7c98d 3/3: Create and document auth-source-reveal-mode
Date: Tue, 23 Jun 2020 22:29:50 +0000 [thread overview]
Message-ID: <v9jhl8kh.fsf@lifelogs.com> (raw)
In-Reply-To: <jwvwo3y95fz.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 22 Jun 2020 17:09:08 -0400")
On Mon, 22 Jun 2020 17:09:08 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
SM> Yes, it's needed first: in some modes, enabling `prettify-symbols-mode`
SM> can lead to really undesirable behavior (e.g. in Haskell it can lead to
SM> code being plain wrong since it can affect indentation and indentation
SM> is semantically significant like in Python). So you really can't impose
SM> it on the unsuspecting user.
Agreed. It was better to start with something cleaner. So, I created a
whole new prettify-text API and reimplemented auth-source-reveal-mode on
top of it. It worked well in my testing.
The new branch is scratch/tzz/prettify-text-mode (I left
scratch/tzz/auth-source-reveal-mode in place as a reference).
The new code won't interfere with existing `prettify-symbols-mode'
users. Eventually `prettify-symbols-mode' could be migrated to this new
API to avoid the code duplication in the post-command-hook and
elsewhere.
If you have suggestions or comments, please let me know. I'll document
the API before I push the branch out.
Ted
next prev parent reply other threads:[~2020-06-23 22:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200622191653.26453.39420@vcs0.savannah.gnu.org>
[not found] ` <20200622191655.E1C4E20A26@vcs0.savannah.gnu.org>
2020-06-22 20:00 ` scratch/tzz/auth-source-reveal-mode f16a4c8 2/3: Support regular expressions and API for prettify-symbols-mode Stefan Monnier
2020-06-22 20:32 ` Ted Zlatanov
[not found] ` <20200622191656.2D20920A26@vcs0.savannah.gnu.org>
2020-06-22 20:03 ` scratch/tzz/auth-source-reveal-mode 4a7c98d 3/3: Create and document auth-source-reveal-mode Stefan Monnier
2020-06-22 20:39 ` Ted Zlatanov
2020-06-22 21:09 ` Stefan Monnier
2020-06-23 22:29 ` Ted Zlatanov [this message]
2020-06-24 15:13 ` Eli Zaretskii
2020-06-24 18:15 ` Ted Zlatanov
2020-06-24 18:36 ` Eli Zaretskii
2020-06-24 19:04 ` Ted Zlatanov
2020-06-25 13:31 ` Eli Zaretskii
2020-06-26 13:52 ` Ted Zlatanov
2020-06-26 14:24 ` Eli Zaretskii
2020-06-26 14:39 ` Ted Zlatanov
2020-07-12 20:49 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9jhl8kh.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.