* Some suggestion WRT gtk related variables
@ 2006-09-18 12:59 Reiner Steib
2006-09-18 13:24 ` Jan Djärv
0 siblings, 1 reply; 2+ messages in thread
From: Reiner Steib @ 2006-09-18 12:59 UTC (permalink / raw)
Cc: emacs-devel
Hi,
`M-x apropos-variable RET gtk- RET' shows...
,----[ M-x apropos-variable RET gtk- RET ]
| x-gtk-show-chooser-help-text
| Variable: *If non-nil, the GTK file chooser will by show additional help text.
| x-gtk-show-hidden-files
| Variable: *If non-nil, the GTK file chooser will by default show hidden files.
| x-gtk-whole-detached-tool-bar
| Variable: *If non-nil, a detached tool bar is shown in full.
| x-use-old-gtk-file-dialog
| Variable: *Non-nil means prompt with the old GTK file selection dialog.
`----
Why do we use the term "chooser" in `x-gtk-show-chooser-help-text' and
the term "file dialog" in `x-use-old-gtk-file-dialog'. I'd suggest to
use "file dialog" in both variables, i.e. rename
`x-gtk-show-chooser-help-text' to `x-gtk-file-dialog-help-text'.
I'd also suggest to rename `x-use-old-gtk-file-dialog' to
`x-gtk-use-old-file-dialog'. Maybe it's doc string should say what is
"old" and "new" in GTK version numbers?
Maybe it would make sense to allow `x-gtk-show-chooser-help-text' to
be nil, t or a (customizable) string instead of the hard coded text:
,----[ gtkutil.c ]
| if (x_gtk_show_chooser_help_text)
| {
| message[0] = '\0';
| if (action != GTK_FILE_CHOOSER_ACTION_SAVE)
| strcat (message, "\nType C-l to display a file name text entry box.\n");
| strcat (message, "\nIf you don't like this file selector, use the "
| "corresponding\nkey binding or customize "
| "use-file-dialog to turn it off.");
|
| wmessage = gtk_label_new (message);
| gtk_widget_show (wmessage);
| }
`----
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Some suggestion WRT gtk related variables
2006-09-18 12:59 Some suggestion WRT gtk related variables Reiner Steib
@ 2006-09-18 13:24 ` Jan Djärv
0 siblings, 0 replies; 2+ messages in thread
From: Jan Djärv @ 2006-09-18 13:24 UTC (permalink / raw)
Reiner Steib skrev:
> Hi,
>
> `M-x apropos-variable RET gtk- RET' shows...
>
> ,----[ M-x apropos-variable RET gtk- RET ]
> | x-gtk-show-chooser-help-text
> | Variable: *If non-nil, the GTK file chooser will by show additional help text.
> | x-gtk-show-hidden-files
> | Variable: *If non-nil, the GTK file chooser will by default show hidden files.
> | x-gtk-whole-detached-tool-bar
> | Variable: *If non-nil, a detached tool bar is shown in full.
> | x-use-old-gtk-file-dialog
> | Variable: *Non-nil means prompt with the old GTK file selection dialog.
> `----
>
> Why do we use the term "chooser" in `x-gtk-show-chooser-help-text' and
> the term "file dialog" in `x-use-old-gtk-file-dialog'. I'd suggest to
> use "file dialog" in both variables, i.e. rename
> `x-gtk-show-chooser-help-text' to `x-gtk-file-dialog-help-text'.
Just because the old file dialog does not have the additional text. The name
of the new dialog is file-chooser. But I can change.
>
> I'd also suggest to rename `x-use-old-gtk-file-dialog' to
> `x-gtk-use-old-file-dialog'. Maybe it's doc string should say what is
> "old" and "new" in GTK version numbers?
That is currently not possible. Both file dialogs exists side by side in at
least Gtk+ version 2.4 to 2.10. I can rename the variable though.
>
> Maybe it would make sense to allow `x-gtk-show-chooser-help-text' to
> be nil, t or a (customizable) string instead of the hard coded text:
Wouldn't that be overkill? The purpose of the text is just to help those that
dislike the new dialog, which seems to be quite a few.
Jan D.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-18 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-18 12:59 Some suggestion WRT gtk related variables Reiner Steib
2006-09-18 13:24 ` Jan Djärv
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.