From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: Some suggestion WRT gtk related variables Date: Mon, 18 Sep 2006 14:59:59 +0200 Message-ID: Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1158584450 23045 80.91.229.2 (18 Sep 2006 13:00:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 18 Sep 2006 13:00:50 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 18 15:00:45 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GPIji-0001Uj-PJ for ged-emacs-devel@m.gmane.org; Mon, 18 Sep 2006 15:00:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GPIji-0007Ku-DC for ged-emacs-devel@m.gmane.org; Mon, 18 Sep 2006 09:00:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GPIjI-0007FO-H0 for emacs-devel@gnu.org; Mon, 18 Sep 2006 09:00:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GPIjG-0007C7-RS for emacs-devel@gnu.org; Mon, 18 Sep 2006 09:00:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GPIjG-0007Bk-JB for emacs-devel@gnu.org; Mon, 18 Sep 2006 09:00:06 -0400 Original-Received: from [134.60.1.1] (helo=mail.uni-ulm.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GPIm6-0005TF-F1 for emacs-devel@gnu.org; Mon, 18 Sep 2006 09:03:02 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.8/8.13.8) with ESMTP id k8ID00sK010411; Mon, 18 Sep 2006 15:00:01 +0200 (MEST) Original-Received: by bridgekeeper.physik.uni-ulm.de (Postfix, from userid 170) id 155DB1203D; Mon, 18 Sep 2006 15:00:00 +0200 (CEST) Original-To: Jan =?iso-8859-1?Q?Dj=E4rv?= X-Face: .*T0'iU(sujq_j9\J>-d4fg; N/1++U#U$_5ii6k.=|"-n'?5O:Hyz&wi'-!I~,}7~GgT=0S /&-R5sbkNy5+Xo1y{Tw2KKxi@Xh"g@]Qc|.U<*]WDd)qvGowFDvfU1F]{EDho:7P0@|oOD=Bc{K4?> WP68K[Mx:}=`ZT'6g4'f+g?;`vri2!)xGy}3:=l'(/Cea0l4lo^H5#@/Z3ev Mail-Followup-To: Jan =?iso-8859-1?Q?Dj=E4rv?= , emacs-devel@gnu.org User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-DCC-EATSERVER-Metrics: gemini 1166; Body=2 Fuz1=2 Fuz2=2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59961 Archived-At: Hi, `M-x apropos-variable RET gtk- RET' shows... ,----[ M-x apropos-variable RET gtk- RET ] | x-gtk-show-chooser-help-text | Variable: *If non-nil, the GTK file chooser will by show additional help text. | x-gtk-show-hidden-files | Variable: *If non-nil, the GTK file chooser will by default show hidden files. | x-gtk-whole-detached-tool-bar | Variable: *If non-nil, a detached tool bar is shown in full. | x-use-old-gtk-file-dialog | Variable: *Non-nil means prompt with the old GTK file selection dialog. `---- Why do we use the term "chooser" in `x-gtk-show-chooser-help-text' and the term "file dialog" in `x-use-old-gtk-file-dialog'. I'd suggest to use "file dialog" in both variables, i.e. rename `x-gtk-show-chooser-help-text' to `x-gtk-file-dialog-help-text'. I'd also suggest to rename `x-use-old-gtk-file-dialog' to `x-gtk-use-old-file-dialog'. Maybe it's doc string should say what is "old" and "new" in GTK version numbers? Maybe it would make sense to allow `x-gtk-show-chooser-help-text' to be nil, t or a (customizable) string instead of the hard coded text: ,----[ gtkutil.c ] | if (x_gtk_show_chooser_help_text) | { | message[0] = '\0'; | if (action != GTK_FILE_CHOOSER_ACTION_SAVE) | strcat (message, "\nType C-l to display a file name text entry box.\n"); | strcat (message, "\nIf you don't like this file selector, use the " | "corresponding\nkey binding or customize " | "use-file-dialog to turn it off."); | | wmessage = gtk_label_new (message); | gtk_widget_show (wmessage); | } `---- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/