all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
Cc: emacs-devel@gnu.org
Subject: Some suggestion WRT gtk related variables
Date: Mon, 18 Sep 2006 14:59:59 +0200	[thread overview]
Message-ID: <v9hcz5qqi8.fsf@marauder.physik.uni-ulm.de> (raw)

Hi,

`M-x apropos-variable RET gtk- RET' shows...

,----[ M-x apropos-variable RET gtk- RET ]
| x-gtk-show-chooser-help-text
|   Variable: *If non-nil, the GTK file chooser will by show additional help text.
| x-gtk-show-hidden-files
|   Variable: *If non-nil, the GTK file chooser will by default show hidden files.
| x-gtk-whole-detached-tool-bar
|   Variable: *If non-nil, a detached tool bar is shown in full.
| x-use-old-gtk-file-dialog
|   Variable: *Non-nil means prompt with the old GTK file selection dialog.
`----

Why do we use the term "chooser" in `x-gtk-show-chooser-help-text' and
the term "file dialog" in `x-use-old-gtk-file-dialog'.  I'd suggest to
use "file dialog" in both variables, i.e. rename
`x-gtk-show-chooser-help-text' to `x-gtk-file-dialog-help-text'.

I'd also suggest to rename `x-use-old-gtk-file-dialog' to
`x-gtk-use-old-file-dialog'.  Maybe it's doc string should say what is
"old" and "new" in GTK version numbers?

Maybe it would make sense to allow `x-gtk-show-chooser-help-text' to
be nil, t or a (customizable) string instead of the hard coded text:

,----[ gtkutil.c ]
|   if (x_gtk_show_chooser_help_text)
|     {
|       message[0] = '\0';
|       if (action != GTK_FILE_CHOOSER_ACTION_SAVE)
|         strcat (message, "\nType C-l to display a file name text entry box.\n");
|       strcat (message, "\nIf you don't like this file selector, use the "
|               "corresponding\nkey binding or customize "
|               "use-file-dialog to turn it off.");
|     
|       wmessage = gtk_label_new (message);
|       gtk_widget_show (wmessage);
|     }
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

             reply	other threads:[~2006-09-18 12:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-18 12:59 Reiner Steib [this message]
2006-09-18 13:24 ` Some suggestion WRT gtk related variables Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9hcz5qqi8.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.