all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Ralf Angeli <angeli@caeruleus.net>, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: declare-function in files from Gnus (hashcash.el, imap.el)
Date: Tue, 04 Dec 2007 00:12:07 +0100	[thread overview]
Message-ID: <v9d4tnxtiw.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <200712022237.lB2MbNC8016800@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 02 Dec 2007 14:37:23 -0800")

On Sun, Dec 02 2007, Dan Nicolaescu wrote:

> Such files can just add a 1 line compatibility code:
>
> (unless (fboundp 'declare-function) (defmacro declare-function (&rest r)))

I think this is not a good idea...

,----[ (info "(elisp)Coding Conventions") ]
|    * If a package needs to define an alias or a new function for
|      compatibility with some other version of Emacs, name it with the
|      package prefix, not with the raw name with which it occurs in the
|      other version.  Here is an example from Gnus, which provides many
|      examples of such compatibility issues.
| 
|           (defalias 'gnus-point-at-bol
|             (if (fboundp 'point-at-bol)
|                 'point-at-bol
|               'line-beginning-position))
`----

[In Gnus, we had some bug report from XEmacs users that was very hard
to find because some XEmacs package defined an un-prefixed Emacs
function so that the test (fboundp ...) returned t although the
functionality was not as expected.]

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

  parent reply	other threads:[~2007-12-03 23:12 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 22:56 declare-function in files from Gnus (hashcash.el, imap.el) Reiner Steib
2007-11-30 23:27 ` Glenn Morris
2007-12-01 18:35   ` Reiner Steib
2007-12-01 18:54     ` Dan Nicolaescu
2007-12-01 20:35       ` Glenn Morris
2007-12-01 20:40         ` Dan Nicolaescu
2007-12-01 21:50     ` Glenn Morris
2007-12-01  9:15 ` Ralf Angeli
2007-12-01 16:34   ` Dan Nicolaescu
2007-12-01 17:09     ` Ralf Angeli
2007-12-01 20:44       ` Stephen J. Turnbull
2006-12-02  0:01         ` Ralf Angeli
2007-12-02  0:33           ` Stephen J. Turnbull
2007-12-01 23:41       ` Richard Stallman
2006-12-01 23:58         ` Ralf Angeli
2007-12-02 21:26           ` Richard Stallman
2006-12-02 21:59             ` Ralf Angeli
2007-12-02 22:37               ` Dan Nicolaescu
2007-12-03 18:28                 ` Ralf Angeli
2007-12-03 23:12                 ` Reiner Steib [this message]
2007-12-03 23:40                   ` Dan Nicolaescu
2007-12-05 20:35                     ` Reiner Steib
2007-12-05 21:01                       ` Glenn Morris
2007-12-08 19:42                         ` Reiner Steib
2007-12-08 22:58                           ` Dan Nicolaescu
2007-12-09  2:20                             ` Glenn Morris
2007-12-09 20:10                               ` Austin Frank
2007-12-09 21:22                                 ` Reiner Steib
2007-12-04 16:55                   ` Richard Stallman
2007-12-02 20:07       ` Dan Nicolaescu
2008-01-05 13:13     ` Patch for focus-frame use in RefTeX (was: declare-function in files from Gnus (hashcash.el, imap.el)) Ralf Angeli
2007-12-01 21:42 ` syncing from Emacs to Gnus [was Re: declare-function in files from Gnus (hashcash.el, imap.el)] Glenn Morris
2007-12-01 23:22   ` syncing from Emacs to Gnus Reiner Steib
2007-12-02 14:56     ` Stefan Monnier
2007-12-02 18:39     ` Richard Stallman
2007-12-03  2:25       ` Stefan Monnier
2007-12-03 18:43         ` Richard Stallman
2007-12-03 18:59           ` Stefan Monnier
2007-12-06  2:12             ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9d4tnxtiw.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=angeli@caeruleus.net \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.