half of emacs lisp files tested positive for trailing whitespace

half of emacs lisp files tested positive for trailing whitespace

[Dan Jacobson]

Gentlemen, wearing my show-trailing-whitespace xray-specs all day long
has made me acutely aware of the waste current these days.  Indeed,
emacs authors should be required to wear them too, as half of the
files on this quick sample returned positive results when tested for
trailing whitespace:

$ find /usr/share/emacs/21.3/lisp/ -name \*.el|LC_ALL=C xargs grep -L ' $'|wc -l
373
$ find /usr/share/emacs/21.3/lisp/ -name \*.el|LC_ALL=C xargs grep -l ' $'|wc -l
386
$ find /usr/share/emacs/21.3/lisp/ -name \*.el|wc -l
759

By the way, I had to use LC_ALL=C due to
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=206470
#206470: LC_CTYPE=C speeds 'grep a' 800 times!
which is the GNU bug of the century in terms of impact on my daily life.

Re: half of emacs lisp files tested positive for trailing whitespace

[Eli Zaretskii]

> From: Dan Jacobson <jidanni@jidanni.org>
> Date: Wed, 24 Dec 2003 04:43:03 +0800
> 
> Gentlemen, wearing my show-trailing-whitespace xray-specs all day long
> has made me acutely aware of the waste current these days.  Indeed,
> emacs authors should be required to wear them too, as half of the
> files on this quick sample returned positive results when tested for
> trailing whitespace:

How about sending patches to remove all that slack?

TIA

Re: half of emacs lisp files tested positive for trailing whitespace

[Reiner Steib]

On Wed, Dec 24 2003, Eli Zaretskii wrote:

[ trailing whitespace in Emacs 21.3 files ] 

> How about sending patches to remove all that slack?

Is it worth to consider this for Emacs 21.3?  IIRC such a clean-up has
already happened for CVS HEAD some months ago.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: half of emacs lisp files tested positive for trailing whitespace

[Alexander Pohoyda]

Eli Zaretskii <eliz@elta.co.il> writes:

> > Gentlemen, wearing my show-trailing-whitespace xray-specs all day long
> > has made me acutely aware of the waste current these days.  Indeed,
> > emacs authors should be required to wear them too, as half of the
> > files on this quick sample returned positive results when tested for
> > trailing whitespace:
> 
> How about sending patches to remove all that slack?

This might be not extra performant, but works:

find ./ -name "*.el" -exec emacs -batch {} --eval="(progn (delete-trailing-whitespace) (and (buffer-modified-p) (save-buffer)))" \;

I think that Dan is right and developers should take care about this
before they commit changes.


-- 
Alexander Pohoyda <alexander.pohoyda@gmx.net>
PGP Key fingerprint: 7F C9 CC 5A 75 CD 89 72  15 54 5F 62 20 23 C6 44

Re: half of emacs lisp files tested positive for trailing whitespace

[Sam Steingold]

> * Alexander Pohoyda <nyrknaqre.cbublqn@tzk.arg> [2003-12-24 15:25:35 +0100]:
>
> Eli Zaretskii <eliz@elta.co.il> writes:
>
>> > Gentlemen, wearing my show-trailing-whitespace xray-specs all day long
>> > has made me acutely aware of the waste current these days.  Indeed,
>> > emacs authors should be required to wear them too, as half of the
>> > files on this quick sample returned positive results when tested for
>> > trailing whitespace:
>> 
>> How about sending patches to remove all that slack?
>
> I think that Dan is right and developers should take care about this
> before they commit changes.

(add-hook 'write-file-functions 'delete-trailing-whitespace)

-- 
Sam Steingold (http://www.podval.org/~sds) running w2k
<http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/>
<http://www.mideasttruth.com/> <http://www.honestreporting.com>
As a computer, I find your faith in technology amusing.