From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: Re: tool bar icons not updated according to :active condition Date: Tue, 28 Feb 2006 15:53:54 +0100 Message-ID: References: <873bi8ok5h.fsf@stupidchicken.com> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1141411119 3485 80.91.229.2 (3 Mar 2006 18:38:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 3 Mar 2006 18:38:39 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 03 19:38:36 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FFFAU-0004pO-4Z for ged-emacs-devel@m.gmane.org; Fri, 03 Mar 2006 19:38:22 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FFFAS-0007eh-H3 for ged-emacs-devel@m.gmane.org; Fri, 03 Mar 2006 13:38:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FEt0E-0003nF-6S for emacs-devel@gnu.org; Thu, 02 Mar 2006 13:58:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FEt08-0003lS-5v for emacs-devel@gnu.org; Thu, 02 Mar 2006 13:58:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FEAY4-0005vq-Ox for emacs-devel@gnu.org; Tue, 28 Feb 2006 14:30:17 -0500 Original-Received: from [134.60.1.1] (helo=mail.uni-ulm.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FE6Fk-000082-1d; Tue, 28 Feb 2006 09:55:04 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.4/8.13.4) with ESMTP id k1SErsff007244; Tue, 28 Feb 2006 15:53:54 +0100 (MET) Original-Received: by bridgekeeper.physik.uni-ulm.de (Postfix, from userid 170) id 3602611076; Tue, 28 Feb 2006 15:53:54 +0100 (CET) Original-To: Richard Stallman In-Reply-To: (Richard Stallman's message of "Mon, 27 Feb 2006 14:02:22 -0500") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-DCC-sonic.net-Metrics: gemini 1156; Body=2 Fuz1=2 Fuz2=2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51083 Archived-At: On Mon, Feb 27 2006, Richard Stallman wrote: > The following gives better results (but of course it is still a > workaround, not a fix). > > What is the underlying bug, for which this is a workaround? The tool bar icons are not updated according to the :active condition. I'm including the original report below. You did already sent two reminder to emacs-devel, and added it to admin/FOR-RELEASE: ,----[ admin/FOR-RELEASE ] | * BUGS | | ** Reiner Steib's 23 Jan 2006 bug report that tool bar icons don't update. | URL/MID: http://mid.gmane.org/v9acdmrcse.fsf@marauder.physik.uni-ulm.de `---- (I have added the URL/MID there.) Bye, Reiner My original report was: --8<---------------cut here---------------start------------->8--- From: Reiner Steib Subject: tool bar icons not updated according to :active condition Date: Mon, 23 Jan 2006 19:59:13 +0100 Message-ID: Reply-To: Reiner Steib To: emacs-devel@gnu.org (easy-menu-define gnus-group-reading-menu gnus-group-mode-map "" `("Group" [...] ["Describe" gnus-group-describe-group :active (gnus-group-group-name) ...] I.e. this menu item should be inactive[1] if the point isn't on a group line (e.g. on non-group lines when using topics mode [2]). In the menu, this works correctly, i.e. the menu item is disabled (probably because the menu is updated when clicking on "Group"). In `gnus-group-make-tool-bar' the describe-group entry is also added to the tool bar (icon: etc/images/gnus/describe-group.xpm): (tool-bar-add-item-from-menu 'gnus-group-describe-group "describe-group" gnus-group-mode-map) But after moving up/down in the group buffer (C-p/C-n), the icon is not updated (enabled/disabled) when changing from a group to a topic line and vice versa. After `C-l' (or after `redraw-frame' [3]), the correct icon is displayed. A workaround could be to redraw the frame after every point-motion (is there a after-point-motion-hook?). Bye, Reiner. [1] ,----[ f gnus-group-group-name RET ] | gnus-group-group-name is a compiled Lisp function in `gnus-group.el'. | (gnus-group-group-name) | | Get the name of the newsgroup on the current line. `---- [2] ,---- | [ Gnus -- 6456 ] | [ misc -- 11 ] | 1: nnml:test | 10: nndraft:drafts | [...] `---- [3] Tested with... (global-set-key (kbd "") (lambda (&optional arg) (interactive) (or arg (setq arg 1)) (next-line arg) (redraw-frame (selected-frame)))) --8<---------------cut here---------------end--------------->8---