23.0.60; Feature request: eval-defun on defcustom :initialize / :set

23.0.60; Feature request: eval-defun on defcustom :initialize / :set

[Reiner Steib]

Hi,

I think `eval-defun' (C-M-x) on a defcustom which has should evaluate
the :initialize or :set function.

Real-life example: Changing the list of regexps in
`smiley-regexp-alist' and doing `C-M-x' has no effect.  I modified and
evaluated the defcustom several times until I noticed that I need to
eval `(smiley-update-cache)' as well before my change does anything.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: 23.0.60; Feature request: eval-defun on defcustom :initialize / :set

[Sam Steingold]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Reiner Steib wrote:
|
| I think `eval-defun' (C-M-x) on a defcustom which has should evaluate
| the :initialize or :set function.
|
| Real-life example: Changing the list of regexps in
| `smiley-regexp-alist' and doing `C-M-x' has no effect.  I modified and
| evaluated the defcustom several times until I noticed that I need to
| eval `(smiley-update-cache)' as well before my change does anything.

it is not obvious that this is correct.
defcustom is similar to defvar which does not set the the variable if it
is already defined.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH9kkMPp1Qsf2qnMcRApnPAJ9fX7UhyrWmOBrNJlxlmp01EEBt0wCfbp1R
FB1CV3xsb8dOrQMgI+IPGHY=
=LvsH
-----END PGP SIGNATURE-----

Re: 23.0.60; Feature request: eval-defun on defcustom :initialize / :set

[Reiner Steib]

On Fri, Apr 04 2008, Sam Steingold wrote:

> Reiner Steib wrote:
> |
> | I think `eval-defun' (C-M-x) on a defcustom which has should evaluate
> | the :initialize or :set function.
[...]
>
> it is not obvious that this is correct.
> defcustom is similar to defvar which does not set the the variable if it
> is already defined.

`eval-defun' _does_ set the variable for both, defvar and defcustom.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: 23.0.60; Feature request: eval-defun on defcustom :initialize / :set

[Sam Steingold]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Reiner Steib wrote:
| On Fri, Apr 04 2008, Sam Steingold wrote:
|
|> Reiner Steib wrote:
|> |
|> | I think `eval-defun' (C-M-x) on a defcustom which has should evaluate
|> | the :initialize or :set function.
| [...]
|> it is not obvious that this is correct.
|> defcustom is similar to defvar which does not set the the variable if it
|> is already defined.
|
| `eval-defun' _does_ set the variable for both, defvar and defcustom.

cool!
maybe lisp-eval-defun should do the same in inferior lisp?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH9m8cPp1Qsf2qnMcRAuNuAJ4zZwmLyR1RmUM4erKDj5n4U9EIUQCeIcV1
NET3LOk8qHAitCxKYqaYfzc=
=iImG
-----END PGP SIGNATURE-----

lisp-eval-defun on defvar (was: 23.0.60; Feature request: eval-defun on defcustom :initialize / :set)

[Reiner Steib]

On Fri, Apr 04 2008, Sam Steingold wrote:

> Reiner Steib wrote:
> | `eval-defun' _does_ set the variable for both, defvar and defcustom.
>
> cool!
> maybe lisp-eval-defun should do the same in inferior lisp?

I have no opinion on this.  But please use a different thread/subject
to discuss this.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

bug#109: 23.0.60; Feature request: eval-defun on defcustom :initialize / :set

[Glenn Morris]

Version: 24.4

Reiner Steib wrote:

> Real-life example: Changing the list of regexps in
> `smiley-regexp-alist' and doing `C-M-x' has no effect.  I modified and
> evaluated the defcustom several times until I noticed that I need to
> eval `(smiley-update-cache)' as well before my change does anything.

Implemented.