From: Reiner Steib <reinersteib+gmane@imap.cc>
Cc: emacs-devel@gnu.org, ding@gnus.org, Miles Bader <miles@gnu.org>
Subject: Re: Changes in calendar/time-date.el
Date: Mon, 04 Apr 2005 19:20:59 +0200 [thread overview]
Message-ID: <v94qembgqs.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <87hdimzou0.fsf@xs4all.nl> (Lute Kamstra's message of "Mon, 04 Apr 2005 14:52:23 +0200")
On Mon, Apr 04 2005, Lute Kamstra wrote:
> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> --- message.el 30 Mar 2005 08:14:32 -0000 1.75
>> +++ message.el 4 Apr 2005 11:36:12 -0000
>> @@ -32,6 +32,8 @@
>>
>> (eval-when-compile
>> (require 'cl)
>> + (defvar parse-time-weekdays) ;; parse-time is required where necessary
>> + (defvar parse-time-months)
>> (defvar gnus-message-group-art)
>> (defvar gnus-list-identifiers)) ; gnus-sum is required where necessary
>> (require 'canlock)
>
> Can't you move this closer to the definition of message-make-date?
> It's only necessary to suppress compiler warnings for that function.
I put it inside the defun.
> Alternatively, you can use (with-no-warnings ...) around references to
> these variables.
`with-no-warnings' isn't available in Emacs 21.
>> --- nnimap.el 18 Mar 2005 02:49:57 -0000 1.23
>> +++ nnimap.el 4 Apr 2005 11:36:12 -0000
>> @@ -69,6 +69,8 @@
>> (require 'gnus-range)
>> (require 'gnus-start)
>> (require 'gnus-int)
>> + ;; Only for `parse-time-months' in `nnimap-date-days-ago':
>> +(require 'parse-time)
>>
>> (eval-when-compile (require 'cl))
>
> Why not put the require in the body of nnimap-date-days-ago?
Okay, then I also need to add a defvar:
(defun nnimap-date-days-ago (daysago)
"Return date, in format \"3-Aug-1998\", for DAYSAGO days ago."
+ (require 'parse-time)
+ (defvar parse-time-months)
(let* ((time (nnimap-time-substract (current-time) (days-to-time daysago)))
(date (format-time-string
(format "%%d-%s-%%Y"
I have committed the changes to Gnus v5-10 branch. If anyone want to
handle the compiler differently, feel free to change it.
Bye, Reiner.
next prev parent reply other threads:[~2005-04-04 17:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1DGYNu-00038g-00@quimby.gnus.org>
[not found] ` <yotly8c5jpi2.fsf@jpl.org>
2005-03-31 11:27 ` Changes in calendar/time-date.el (was: CVS update of gnus/lisp (4 files)) Reiner Steib
2005-03-31 12:20 ` Miles Bader
2005-03-31 12:58 ` Changes in calendar/time-date.el Lute Kamstra
2005-03-31 22:52 ` Miles Bader
2005-04-01 4:10 ` Richard Stallman
2005-04-04 10:25 ` Reiner Steib
2005-04-04 10:57 ` Lute Kamstra
2005-04-04 12:09 ` Reiner Steib
2005-04-04 12:52 ` Lute Kamstra
2005-04-04 17:20 ` Reiner Steib [this message]
2005-04-04 19:50 ` Stefan Monnier
2005-04-05 7:14 ` Kim F. Storm
2005-04-05 9:33 ` Miles Bader
2005-04-05 10:06 ` Kim F. Storm
2005-04-07 12:47 ` require inside functions. (was: Changes in calendar/time-date.el) Lute Kamstra
2005-04-07 21:45 ` Kim F. Storm
2005-04-08 0:12 ` require inside functions Miles Bader
2005-04-08 0:45 ` Stefan Monnier
2005-04-08 2:09 ` Miles Bader
2005-04-08 0:21 ` Stefan Monnier
2005-04-08 3:22 ` require inside functions. (was: Changes in calendar/time-date.el) Richard Stallman
2005-04-08 8:12 ` Kim F. Storm
2005-04-09 3:38 ` require inside functions. (was: Changes in Richard Stallman
2005-04-09 9:30 ` require inside functions Lute Kamstra
2005-04-10 1:55 ` Richard Stallman
2005-04-13 9:11 ` Lute Kamstra
2005-04-15 2:44 ` Richard Stallman
2005-04-15 9:23 ` Lute Kamstra
2005-04-08 8:16 ` David Kastrup
2005-04-05 13:54 ` Changes in calendar/time-date.el Lute Kamstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v94qembgqs.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=reiner.steib@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.