* help-mode changes
[not found] <E1FVxad-0008T2-UW@savannah.gnu.org>
@ 2006-04-19 6:46 ` Romain Francoise
2006-04-19 12:36 ` Reiner Steib
2006-04-24 17:52 ` Richard Stallman
0 siblings, 2 replies; 5+ messages in thread
From: Romain Francoise @ 2006-04-19 6:46 UTC (permalink / raw)
Cc: emacs-devel
This change:
2006-04-18 Richard Stallman <rms@gnu.org>
* help-mode.el (help-mode): Set view-exit-action to delete window.
causes a bug: hitting `q' in a *Help* buffer now signals the following
error: ``Attempt to delete minibuffer or sole ordinary window''.
"Richard M. Stallman" <rms@gnu.org> writes:
> Index: emacs/lisp/help-mode.el
> diff -u emacs/lisp/help-mode.el:1.44 emacs/lisp/help-mode.el:1.45
> --- emacs/lisp/help-mode.el:1.44 Mon Mar 20 00:42:21 2006
> +++ emacs/lisp/help-mode.el Tue Apr 18 21:18:27 2006
> @@ -197,6 +197,7 @@
> (view-mode)
> (make-local-variable 'view-no-disable-on-exit)
> (setq view-no-disable-on-exit t)
> + (setq view-exit-action (lambda (buffer) (delete-window)))
> (run-mode-hooks 'help-mode-hook))
>
> ;;;###autoload
--
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
| ever free! --Bryan W. Procter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: help-mode changes
2006-04-19 6:46 ` help-mode changes Romain Francoise
@ 2006-04-19 12:36 ` Reiner Steib
2006-04-24 17:52 ` Richard Stallman
1 sibling, 0 replies; 5+ messages in thread
From: Reiner Steib @ 2006-04-19 12:36 UTC (permalink / raw)
Cc: Richard M. Stallman, emacs-devel
On Wed, Apr 19 2006, Romain Francoise wrote:
> 2006-04-18 Richard Stallman <rms@gnu.org>
>
> * help-mode.el (help-mode): Set view-exit-action to delete window.
>
> causes a bug: hitting `q' in a *Help* buffer now signals the following
> error: ``Attempt to delete minibuffer or sole ordinary window''.
[...]
>> (setq view-no-disable-on-exit t)
>> + (setq view-exit-action (lambda (buffer) (delete-window)))
>> (run-mode-hooks 'help-mode-hook))
I see another bug introduced by this change. To reproduce:
emacs -Q -eval '(push "*Help*" special-display-buffer-names)'
C-x 2
C-x b RET
==> the frame contains the *Messages* window above the *scratch*
C-h f gnus RET
Focus the *Help* buffer
Hit `q'
==> the *Messages* window was deleted, only the *scratch* buffer is
visible.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: help-mode changes
2006-04-19 6:46 ` help-mode changes Romain Francoise
2006-04-19 12:36 ` Reiner Steib
@ 2006-04-24 17:52 ` Richard Stallman
2006-04-25 13:21 ` Reiner Steib
1 sibling, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2006-04-24 17:52 UTC (permalink / raw)
Cc: emacs-devel
Does this fix the problems?
*** help-mode.el 09 Apr 2006 21:14:58 -0400 1.45
--- help-mode.el 20 Apr 2006 12:00:28 -0400
***************
*** 197,203 ****
(view-mode)
(make-local-variable 'view-no-disable-on-exit)
(setq view-no-disable-on-exit t)
! (setq view-exit-action (lambda (buffer) (delete-window)))
(run-mode-hooks 'help-mode-hook))
;;;###autoload
--- 197,206 ----
(view-mode)
(make-local-variable 'view-no-disable-on-exit)
(setq view-no-disable-on-exit t)
! (setq view-exit-action (lambda (buffer)
! (or (window-minibuffer-p (selected-window))
! (one-window-p t)
! (delete-window))))
(run-mode-hooks 'help-mode-hook))
;;;###autoload
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: help-mode changes
2006-04-24 17:52 ` Richard Stallman
@ 2006-04-25 13:21 ` Reiner Steib
2006-04-29 3:50 ` Richard Stallman
0 siblings, 1 reply; 5+ messages in thread
From: Reiner Steib @ 2006-04-25 13:21 UTC (permalink / raw)
Cc: Romain Francoise, emacs-devel, Reiner Steib
On Mon, Apr 24 2006, Richard Stallman wrote:
> Does this fix the problems?
[...]
> ! (setq view-exit-action (lambda (buffer)
> ! (or (window-minibuffer-p (selected-window))
> ! (one-window-p t)
> ! (delete-window))))
> (run-mode-hooks 'help-mode-hook))
No. The code still deletes the second window using the recipe I gave
in <v94q0pkail.fsf@marauder.physik.uni-ulm.de>.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: help-mode changes
2006-04-25 13:21 ` Reiner Steib
@ 2006-04-29 3:50 ` Richard Stallman
0 siblings, 0 replies; 5+ messages in thread
From: Richard Stallman @ 2006-04-29 3:50 UTC (permalink / raw)
Cc: romain, emacs-devel, reinersteib+gmane
C-h f gnus RET
Focus the *Help* buffer
Hit `q'
==> the *Messages* window was deleted, only the *scratch* buffer is
visible.
It does not happen for me now.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-04-29 3:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1FVxad-0008T2-UW@savannah.gnu.org>
2006-04-19 6:46 ` help-mode changes Romain Francoise
2006-04-19 12:36 ` Reiner Steib
2006-04-24 17:52 ` Richard Stallman
2006-04-25 13:21 ` Reiner Steib
2006-04-29 3:50 ` Richard Stallman
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.