From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel Subject: 23.0.50; tool bar icons disappear Date: Sat, 08 Dec 2007 12:56:42 +0100 Message-ID: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1197115189 22393 80.91.229.12 (8 Dec 2007 11:59:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Dec 2007 11:59:49 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 08 12:59:59 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J0yLd-0007q0-7Y for ged-emacs-devel@m.gmane.org; Sat, 08 Dec 2007 12:59:57 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J0yLL-0001bw-Sa for ged-emacs-devel@m.gmane.org; Sat, 08 Dec 2007 06:59:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J0yK5-0000X3-Pz for emacs-devel@gnu.org; Sat, 08 Dec 2007 06:58:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J0yK4-0000WP-VQ for emacs-devel@gnu.org; Sat, 08 Dec 2007 06:58:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J0yK4-0000WI-Op for emacs-devel@gnu.org; Sat, 08 Dec 2007 06:58:20 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J0yK4-0002Lc-60 for emacs-devel@gnu.org; Sat, 08 Dec 2007 06:58:20 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1J0yJm-00053J-5u for emacs-devel@gnu.org; Sat, 08 Dec 2007 11:58:02 +0000 Original-Received: from p54a95d1e.dip.t-dialin.net ([84.169.93.30]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 08 Dec 2007 11:58:02 +0000 Original-Received: from Reiner.Steib by p54a95d1e.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 08 Dec 2007 11:58:02 +0000 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 139 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: p54a95d1e.dip.t-dialin.net X-Face: 1; h7XMU[7l}$T@J.D}5z*w8Tg'}B5ArAWc8>2X~otB; kOjKs8X%|hTC#dG:%Vpx")x7S/`v :VXU#fZW$X$zdhEU.RfVQ@<-m9IuN{Hm"fW{,5]6kR'M*vEs+{5Cj!L(JTRzA$(},?5J=sm; %Od List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84869 Archived-At: > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug: emacs -Q M-x customize-variable RET savehist-mode RET ==> All tool bar icons disappear. The tool bar area and thus the whole frame shrinks. ,----[ v tool-bar-map RET ] | tool-bar-map is a variable defined in `[...]/emacs/lisp/tool-bar.elc'. | Its value is shown below. | | Documentation: | Keymap for the tool bar. | Define this locally to override the global tool bar. | | Value: nil | Local in buffer *Customize Option: Savehist Mode*; global value is | (keymap | (new-file menu-item "Visit New File..." find-file | [...] `---- ,----[ v tool-bar-mode RET ] | tool-bar-mode is a variable defined in `[...]/emacs/lisp/tool-bar.elc'. | Its value is t | | Documentation: | Non-nil if Tool-Bar mode is enabled. | See the command `tool-bar-mode' for a description of this minor mode. | Setting this variable directly does not take effect; | either customize it (see the info node `Easy Customization') | or call the function `tool-bar-mode'. | | You can customize this variable. `---- I'd guess that the following changes might be relevant: ,----[ lisp/ChangeLog ] | 2007-07-05 Chong Yidong | | * cus-edit.el (custom-commands): New variable. | (custom-tool-bar-map): New variable. Initialize using | `custom-commands'. | (custom-mode): Use `custom-tool-bar-map'. | [...] `---- Is the following code in `cus-edit.el' correct? Is this code evaluated at compile time (when `display-graphic-p' returns nil?)? --8<---------------cut here---------------start------------->8--- (defvar tool-bar-map) (defvar custom-tool-bar-map (if (display-graphic-p) (let ((map (make-sparse-keymap))) (mapc (lambda (arg) (tool-bar-local-item-from-menu (nth 1 arg) (nth 4 arg) map custom-mode-map)) custom-commands) map))) --8<---------------cut here---------------end--------------->8--- [BTW, using `when' would make the code more readable. Shouldn't the variable have a doc string?] ,----[ v custom-tool-bar-map RET ] | custom-tool-bar-map is a variable defined in `[...]/emacs/lisp/cus-edit.elc'. | Its value is nil | | Documentation: | Not documented as a variable. `---- The problem doesn't exist neither in Emacs 22.1 nor in EMACS_22_BASE. > In GNU Emacs 23.0.50.7 (i686-pc-linux-gnu, GTK+ Version 2.10.6) > of 2007-12-08 on viandante > Windowing system distributor `The X.Org Foundation', version 11.0.70199902 > configured using `configure '--prefix=/import/xtra/emacs/HEAD' > '--with-gtk' '--exec-prefix=/import/xtra/emacs/HEAD-i686' > 'CFLAGS=-Wno-pointer-sign -O0 -fno-crossjumping -gdwarf-2 -g3'' > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: nil > value of $LC_CTYPE: nil > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: en_US.UTF-8 > locale-coding-system: utf-8 > default-enable-multibyte-characters: t > Major mode: Custom > Minor modes in effect: > tooltip-mode: t > tool-bar-mode: t > mouse-wheel-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > unify-8859-on-encoding-mode: t > utf-translate-cjk-mode: t > auto-compression-mode: t > line-number-mode: t > Recent input: > M-x c u s t o m i z w e - v a r i a b e > l l e s a v e h i > s t - m o d e v t o o l 0 > - b a r - m a C-x 2 v t o o l - > b a r - m o d e > M-x r e p o r > Recent messages: > For information about GNU Emacs and the GNU system, type C-h C-a. > Creating customization items... > Loading savehist...done > Creating customization items ...done > Resetting customization items...done > Creating customization setup...done > Type C-x 1 to delete the help window, C-M-v to scroll help. > Making completion list... Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/