22.2.50; doc strings: menu-bar-mode scroll-bar-mode tool-bar-mode

22.2.50; doc strings: menu-bar-mode scroll-bar-mode tool-bar-mode

[Reiner Steib]

Hi,

maybe the doc strings of menu-bar-mode, scroll-bar-mode and
tool-bar-mode should be unified with regards to the numeric arguments.
Currently, some of the doc strings mention positive, some negative
arguments:

| (menu-bar-mode &optional arg)
| [...] 
| With a numeric argument, if the argument is positive,
| turn on menu bars; otherwise, turn off menu bars.

| (scroll-bar-mode &optional flag)
| [...]
| With a numeric argument, if the argument is negative,
| turn off scroll bars; otherwise, turn on scroll bars.

| (tool-bar-mode &optional arg)
| [...]
| With numeric arg, display the tool bar if and only if arg is positive.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: 22.2.50; doc strings: menu-bar-mode scroll-bar-mode tool-bar-mode

[Johan Bockgård]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> | (scroll-bar-mode &optional flag)
> | [...]
> | With a numeric argument, if the argument is negative,
> | turn off scroll bars; otherwise, turn on scroll bars.

Actually, `(scroll-bar-mode 0)' does turn on the mode.  So the doc
correctly describes its behavior, but the behavior is wrong.  (The Emacs
manual says "With an argument, it turns use of scroll bars on if and
only if the argument is positive.")

-- 
Johan Bockgård

Re: 22.2.50; doc strings: menu-bar-mode scroll-bar-mode tool-bar-mode

[Stefan Monnier]

>> | (scroll-bar-mode &optional flag)
>> | [...]
>> | With a numeric argument, if the argument is negative,
>> | turn off scroll bars; otherwise, turn on scroll bars.

> Actually, `(scroll-bar-mode 0)' does turn on the mode.

Does it?  Sounds like a bug.  Could someone make it use
define-minor-mode to avoid such inconsistency.


        Stefan