From: Glenn Morris <rgm@gnu.org>
To: 10650@debbugs.gnu.org
Subject: bug#10650: view-mode inconsistencies wrt special mode-class
Date: Mon, 30 Jan 2012 04:05:16 -0500 [thread overview]
Message-ID: <v87h09r25v.fsf@fencepost.gnu.org> (raw)
Package: emacs
Version: 24.0.93
Severity: minor
emacs -Q
M-x view-file RET /path/to/old/rmail/BABYL/file RET
-> "Not using View mode because the major mode is special"
but:
emacs -Q
M-x view-file-other-window RET /path/to/old/rmail/BABYL/file/RET
-> buffer opened in view mode.
This is a silly inconsistency. The test for special mode class was
already generalized (bug#5513) from view-file to view-buffer, but none
of the other view-mode commands (view-file-other-window,
view-file-other-frame, view-buffer-other-window,
view-buffer-other-frame) use view-buffer, so this doesn't affect them.
The check should probably be moved to view-mode-enter. This is used in a
handful of places outside view.el, so maybe an optional argument to
control the check will be needed.
When this is done, view-mode will treat special mode class consistently,
so it can be documented in the manual (the relation between view-mode
and special modes does not seem to documented at present). See the Emacs
24 etc/NEWS entry for view buffer.
next reply other threads:[~2012-01-30 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 9:05 Glenn Morris [this message]
2012-01-30 20:10 ` bug#10650: view-mode inconsistencies wrt special mode-class Glenn Morris
2012-01-30 23:29 ` Juri Linkov
2012-01-31 0:38 ` Glenn Morris
2012-01-31 1:49 ` Stefan Monnier
2012-01-31 2:50 ` Glenn Morris
2012-01-31 6:17 ` Chong Yidong
2012-01-31 17:37 ` Stefan Monnier
2012-02-01 7:38 ` Glenn Morris
2012-02-01 8:32 ` Chong Yidong
2012-02-01 17:15 ` Glenn Morris
2012-02-01 14:31 ` Stefan Monnier
2012-02-01 17:12 ` Glenn Morris
2012-02-02 0:40 ` Juri Linkov
2012-02-02 18:49 ` Stefan Monnier
2012-02-02 20:03 ` Glenn Morris
2012-02-02 21:11 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v87h09r25v.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=10650@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.