all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: rcopley@gmail.com, 17884@debbugs.gnu.org
Subject: bug#17884: 24.3.92; `vc-next-action' discards commit message
Date: Sat, 12 Jul 2014 16:25:20 -0400	[thread overview]
Message-ID: <v0tx6mpbnz.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <53C0A6D0.3060806@cs.ucla.edu> (Paul Eggert's message of "Fri, 11 Jul 2014 20:09:04 -0700")

Paul Eggert wrote:

> bzr 117371 didn't use log-edit-empty-buffer-p, as its module might not
> be loaded and I didn't want to introduce an unnecessary dependency.
> But perhaps the dependency is necessary after all.

I don't see the issue.
We are talking about vc-dispatcher calling log-edit, which is defined in
log-edit.el, which is also where log-edit-empty-buffer-p is defined.
So just make vc-log-edit explicitly require log-edit?

For the other thing I mentioned, I think checking whether there is an
existing local value of vc-log-fileset that matches the new one should
cover it.





  reply	other threads:[~2014-07-12 20:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 15:23 bug#17884: 24.3.92; `vc-next-action' discards commit message Richard Copley
2014-06-30 15:39 ` Glenn Morris
2014-06-30 17:35   ` Richard Copley
2014-06-30 19:33   ` Glenn Morris
2014-07-12  2:25 ` Paul Eggert
2014-07-12  2:56   ` Glenn Morris
2014-07-12  3:09     ` Paul Eggert
2014-07-12 20:25       ` Glenn Morris [this message]
2014-07-14 19:31         ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v0tx6mpbnz.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=17884@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=rcopley@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.