From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Minor src/xmenu.c change for older GCC versions
Date: Sun, 05 Nov 2006 14:06:31 +0200 [thread overview]
Message-ID: <uzmb62j3s.fsf@gnu.org> (raw)
In-Reply-To: <20061105080057.GA15931@kobe.laptop> (message from Giorgos Keramidas on Sun, 5 Nov 2006 10:00:57 +0200)
> Date: Sun, 5 Nov 2006 10:00:57 +0200
> From: Giorgos Keramidas <keramida@ceid.upatras.gr>
> Cc: Chong Yidong <cyd@stupidchicken.com>, emacs-devel@gnu.org
> >
> > Please add a comment explaining why this is necessary, to make sure
> > people don't take this out for elegance's sake.
>
> Good point. Sorry I didn't add a comment originally. I thought
> mentioning it in the commit log would be sufficient for now :)
It's actually the other way around: the ChangeLog entry should only
tell WHAT has been changed; the WHY should be in the comments to the
code. See the GNU coding standards for more about this.
next prev parent reply other threads:[~2006-11-05 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 21:50 Minor src/xmenu.c change for older GCC versions Giorgos Keramidas
2006-11-04 3:21 ` Chong Yidong
2006-11-05 7:07 ` Richard Stallman
2006-11-05 8:00 ` Giorgos Keramidas
2006-11-05 12:06 ` Eli Zaretskii [this message]
2006-11-05 13:18 ` Giorgos Keramidas
2006-11-05 17:31 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uzmb62j3s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.