From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: next-error-highlight = t - highlighting doesn't stay until you moveto the next locus Date: Sat, 24 Mar 2007 19:43:05 +0200 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1174758198 18280 80.91.229.12 (24 Mar 2007 17:43:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 24 Mar 2007 17:43:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 24 18:43:16 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HVAGo-0001pF-JR for ged-emacs-devel@m.gmane.org; Sat, 24 Mar 2007 18:43:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HVAIq-0008P2-QA for ged-emacs-devel@m.gmane.org; Sat, 24 Mar 2007 12:45:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HVAIm-0008KQ-SW for emacs-devel@gnu.org; Sat, 24 Mar 2007 13:45:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HVAIl-0008IR-AN for emacs-devel@gnu.org; Sat, 24 Mar 2007 13:45:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HVAIl-0008IG-77 for emacs-devel@gnu.org; Sat, 24 Mar 2007 12:45:15 -0500 Original-Received: from heller.inter.net.il ([213.8.233.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HVAGi-0001aW-59 for emacs-devel@gnu.org; Sat, 24 Mar 2007 13:43:08 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-200-243.inter.net.il [80.230.200.243]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id CER10076 (AUTH halo1); Sat, 24 Mar 2007 19:43:03 +0200 (IST) In-reply-to: X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68489 Archived-At: > From: "Drew Adams" > Cc: > Date: Sat, 24 Mar 2007 09:50:25 -0700 > > > > The doc string says: > > > > > > "If t, highlight the locus indefinitely until some > > > other locus replaces it." > > > > > > I wish it were so. However, the code says this: > > > > > > (if (or (eq next-error-highlight t) > > > (numberp next-error-highlight)) > > > ;; We want highlighting: > > > ;; delete overlay on next input. <---------- NOT GOOD > > > (add-hook 'pre-command-hook 'compilation-goto-locus-delete-o) > > > ... > > > > I cannot find this code in the current CVS version of simple.el > > (assuming that this where you take it from). Please see if the latest > > code still has the problem. > > Yes, the latest code in CVS still has the problem. See the definition of > `compilation-goto-locus' in compile.el. Thanks for looking into this. If I understand correctly, the problem is that `next-error-highlight's documentation on simple.el is inconsistent with what `compilation-goto-locus' (from compile.el) actually does. I don't know how to fix that, since next-error-highlight' is a general-purpose variable, whose use is not limited to compile.el. This is certainly not a simple doc string problem, so perhaps we should leave this until after the release.