From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tool-bar and multi-tty Date: Fri, 10 Oct 2008 09:51:57 +0200 Message-ID: References: <873aj56v2p.fsf@cyd.mit.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1223625139 29137 80.91.229.12 (10 Oct 2008 07:52:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Oct 2008 07:52:19 +0000 (UTC) Cc: 1133@emacsbugs.donarmstrong.com, dann@ics.uci.edu, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 10 09:53:16 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KoCoB-00009I-Rx for ged-emacs-devel@m.gmane.org; Fri, 10 Oct 2008 09:53:12 +0200 Original-Received: from localhost ([127.0.0.1]:58037 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KoCn7-0006xC-QM for ged-emacs-devel@m.gmane.org; Fri, 10 Oct 2008 03:52:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KoCn2-0006wd-SZ for emacs-devel@gnu.org; Fri, 10 Oct 2008 03:52:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KoCn2-0006wD-5Y for emacs-devel@gnu.org; Fri, 10 Oct 2008 03:52:00 -0400 Original-Received: from [199.232.76.173] (port=37248 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KoCn2-0006wA-2e for emacs-devel@gnu.org; Fri, 10 Oct 2008 03:52:00 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:16710) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KoCn2-0000eO-Mf for emacs-devel@gnu.org; Fri, 10 Oct 2008 03:52:00 -0400 Original-Received: from mtaout1.012.net.il ([84.95.2.1]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KoCn0-0001P5-RP for emacs-devel@gnu.org; Fri, 10 Oct 2008 03:51:59 -0400 Original-Received: from HOME-C4E4A596F7 ([77.127.3.182]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K8I000C1J8Q2SE0@i-mtaout1.012.net.il> for emacs-devel@gnu.org; Fri, 10 Oct 2008 09:53:15 +0200 (IST) In-reply-to: <873aj56v2p.fsf@cyd.mit.edu> X-012-Sender: halo1@inter.net.il X-detected-kernel: by mx20.gnu.org: Solaris 9.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104451 Archived-At: > From: Chong Yidong > Date: Thu, 09 Oct 2008 22:30:06 -0400 > Cc: 1133@emacsbugs.donarmstrong.com, emacs-devel@gnu.org > > Bug 1133 notes a problem with tool-bars and multi-tty. Basically, > tool-bar-map is not set up if the first frame is on a tty; it is only > initialized when the first graphical frame is created. This causes > problems for major modes that define their own tool-bar maps. > > I think the solution is to define a normal hook, tool-bar-setup-hook, to > be run after the tool-bar is set up successfully for the first time. This sounds like a very complicated solution. Why can't we set up tool-bar-map unconditionally? Perhaps changes that make that possible are much smaller and cleaner than what you suggest here?