From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacsclient's option decoding code Date: Tue, 11 Nov 2008 06:09:19 +0200 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1226376574 1928 80.91.229.12 (11 Nov 2008 04:09:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Nov 2008 04:09:34 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 11 05:10:35 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KzkaH-0007MK-Ft for ged-emacs-devel@m.gmane.org; Tue, 11 Nov 2008 05:10:33 +0100 Original-Received: from localhost ([127.0.0.1]:57677 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzkZ9-0002mf-HO for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2008 23:09:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KzkZ5-0002ma-4u for emacs-devel@gnu.org; Mon, 10 Nov 2008 23:09:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KzkZ3-0002mO-5u for emacs-devel@gnu.org; Mon, 10 Nov 2008 23:09:17 -0500 Original-Received: from [199.232.76.173] (port=45434 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzkZ3-0002mL-2n for emacs-devel@gnu.org; Mon, 10 Nov 2008 23:09:17 -0500 Original-Received: from mtaout3.012.net.il ([84.95.2.7]:29264) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KzkZ2-00063J-LC for emacs-devel@gnu.org; Mon, 10 Nov 2008 23:09:16 -0500 Original-Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KA500100I9G1300@i_mtaout3.012.net.il> for emacs-devel@gnu.org; Tue, 11 Nov 2008 06:11:03 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.241.172]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KA50054ZIAF9V12@i_mtaout3.012.net.il>; Tue, 11 Nov 2008 06:11:03 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105552 Archived-At: > Date: Mon, 10 Nov 2008 19:22:08 +0100 > From: "Juanma Barranquero" > Cc: cyd@stupidchicken.com, emacs-devel@gnu.org > > Summary of pending issues in this thread: > > - emacsclient -t causes a crash / assertion error; filed as bug#1325. That's fine; I'd like to try to fix this problem. > - emacsclient -c causes the same error, because emacsclient thinks > that "-c" + null DISPLAY => "-t"; I proposed the attached patch (1), > because even if -t is supported on Windows, the assumption that an > empty DISPLAY implies a tty frame is false. Then why is the patch Windows-specific? If the above assumption is false, it shouldn't be made on Posix platforms as well. Can someone explain why this assumption is in the code? > - (make-frame-on-display nil ...) is a synonym of (make-frame ...), > but only on Windows; I proposed patch (2). Does anyone see a problem > with it? What happens if emacsclient is invoked with --display=DISPLAY argument on Windows, after your patch? > - Regardless of whether the previous point is accepted or not, the > new behavior should be documented. Please add an entry to NEWS, so we won't forget that. Thanks.