From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Glenn Morris <rgm@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: /srv/bzr/emacs/trunk r102063: * src/frame.c (syms_of_frame)
	<menu-bar-mode>: Sync doc with Lisp.
Date: Thu, 28 Oct 2010 23:29:52 -0400
Message-ID: <uy62wlk767.fsf@fencepost.gnu.org>
References: <E1P9mP4-0006Cv-8n@internal.in.savannah.gnu.org>
	<jwvhbgcpetd.fsf-monnier+emacs@gnu.org>
	<4ky69oxsdf.fsf@fencepost.gnu.org>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: dough.gmane.org 1288323015 24923 80.91.229.12 (29 Oct 2010 03:30:15 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Fri, 29 Oct 2010 03:30:15 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 29 05:30:12 2010
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1PBffO-0004le-Rt
	for ged-emacs-devel@m.gmane.org; Fri, 29 Oct 2010 05:30:11 +0200
Original-Received: from localhost ([127.0.0.1]:35737 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1PBffN-0007zw-6w
	for ged-emacs-devel@m.gmane.org; Thu, 28 Oct 2010 23:30:09 -0400
Original-Received: from [140.186.70.92] (port=33593 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PBff8-0007uR-Ab
	for emacs-devel@gnu.org; Thu, 28 Oct 2010 23:29:55 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rgm@gnu.org>) id 1PBff7-0006o6-CJ
	for emacs-devel@gnu.org; Thu, 28 Oct 2010 23:29:54 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10]:39121)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1PBff7-0006o1-9Z
	for emacs-devel@gnu.org; Thu, 28 Oct 2010 23:29:53 -0400
Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.69)
	(envelope-from <rgm@gnu.org>)
	id 1PBff6-0000vF-DB; Thu, 28 Oct 2010 23:29:52 -0400
X-Spook: MD2 fraud Roswell Hamas INSCOM lynch JSOFC3IP number key
X-Ran: ;IDMP3UAo7w|*<1J+*}uV#Q^N2'#[@Y8^4w-3ZS&/GGEgoP&JkCp)9d\U*N~5WvtucZm!?
X-Hue: white
X-Attribution: GM
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:132167
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/132167>

Glenn Morris wrote:

>>>   * src/frame.c (syms_of_frame) <menu-bar-mode>: Sync doc with Lisp.
>>
>> Couldn't we drop one of the two docstrings instead?
>
> One is created automatically by the define-minor-mode macro.
> This affects a few other things, eg auto-composition-mode,
> tool-bar-mode, transient-mark-mode, abbrev-mode.

I discovered that by adding an explicit :variable to the
define-minor-mode call, it won't define variables a second time.